Bug 85794

Summary: MediaStream API: Adding the possibility of port specific information in MediaStreamDescriptor
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Tommy Widenflycht 2012-05-07 05:20:36 PDT 
To facilitate for ports I have added two fields to MediaStreamDescriptor:
1) A id (string) field where ports can give MSD an unique id. Needed because the label field is usable for this purpose.
2) An userData field (uint64_t) that can be used for whatever purpose is needed.
Comment 1 Tommy Widenflycht 2012-05-07 05:27:55 PDT 
Created attachment 140513 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-07 05:31:11 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-05-07 10:14:15 PDT 
Comment on attachment 140513 [details]
Patch

The approach we usually use here is to create an ExtraData object that the client can subclass and use to store extra data on these objects.  Take a look at WebURLRequest::ExtraData for an example of how this works.
Comment 4 Tommy Widenflycht 2012-05-08 06:59:25 PDT 
Created attachment 140710 [details]
Patch
Comment 5 Tommy Widenflycht 2012-05-08 07:01:16 PDT 
Fixed.

(In reply to comment #3)
> (From update of attachment 140513 [details])
> The approach we usually use here is to create an ExtraData object that the client can subclass and use to store extra data on these objects.  Take a look at WebURLRequest::ExtraData for an example of how this works.
Comment 6 Adam Barth 2012-05-08 09:29:00 PDT 
Comment on attachment 140710 [details]
Patch

This looks fine, but please remove the m_id property.  It doesn't seem to serve any purpose in WebKit.  If the embedder wants to use an ID, it can put one in ExtraData.
Comment 7 Tommy Widenflycht 2012-05-09 01:07:02 PDT 
Created attachment 140883 [details]
Patch
Comment 8 Tommy Widenflycht 2012-05-09 01:07:40 PDT 
(In reply to comment #6)
> (From update of attachment 140710 [details])
> This looks fine, but please remove the m_id property.  It doesn't seem to serve any purpose in WebKit.  If the embedder wants to use an ID, it can put one in ExtraData.

Fixed.
Comment 9 WebKit Review Bot 2012-05-09 08:48:20 PDT 
Comment on attachment 140883 [details]
Patch

Clearing flags on attachment: 140883

Committed r116529: <http://trac.webkit.org/changeset/116529>
Comment 10 WebKit Review Bot 2012-05-09 08:48:26 PDT 
All reviewed patches have been landed.  Closing bug.