Summary: | [Chromium] Move createMessagePortChannel to Platform.h | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||||||||
Component: | WebKit Misc. | Assignee: | Mark Pilgrim (Google) <pilgrim> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, haraken, jamesr, tkent+wkapi, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 86559 | ||||||||||||
Bug Blocks: | 82948 | ||||||||||||
Attachments: |
|
Description
Mark Pilgrim (Google)
2012-05-06 19:36:09 PDT
Created attachment 140456 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 140456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140456&action=review > Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:-60 > -class WebMessagePortChannel; // FIXME: Does this belong in platform? We'll also want to move WebMessagePortChannel and WebMessagePortChannelClient int Source/Platform/chromium/public as well. They look like they'll move cleanly, so the answer to this comment seems to be "yes". > Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp:46 > namespace WebCore { Once you move WebMessagePortChannel into Source/Platform/chromium/public, you can move all this code into WebCore/platform where it belongs. :) Created attachment 142067 [details]
Patch
Comment on attachment 142067 [details]
Patch
Now moves WebMessagePortChannel and WebMessagePortChannelClient.
Comment on attachment 142067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142067&action=review > Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp:46 > namespace WebCore { This patch is great. Thanks! A good followup patch might be to try to move this code in the WebCore namespace into Source/WebCore/platform/chromium. Comment on attachment 142067 [details] Patch Clearing flags on attachment: 142067 Committed r117204: <http://trac.webkit.org/changeset/117204> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by 86559 Created attachment 146012 [details]
Patch
Comment on attachment 146012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146012&action=review > Source/WebKit/chromium/public/WebFrame.h:42 > +#include <public/WebMessagePortChannel.h> The #includes in Source/WebKit/chromium/public should use forwarding headers, like WebURL.h above. > Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp:123 > PlatformMessagePortChannel::PlatformMessagePortChannel() This whole class should probably move into WebCore. (Feel free to move PlatformMessagePortChannel in a followup patch.) Created attachment 146080 [details]
Patch
Comment on attachment 146080 [details]
Patch
reverted headers in chromium/public/
Comment on attachment 146080 [details] Patch Clearing flags on attachment: 146080 Committed r119666: <http://trac.webkit.org/changeset/119666> All reviewed patches have been landed. Closing bug. |