Bug 85762

Summary: [Chromium] Move queryLocalizedString to Platform.h
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, haraken, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 87299    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2012-05-06 19:19:28 PDT
[Chromium] Move queryLocalizedString to Platform.h
Attachments
Patch (12.93 KB, patch)
2012-05-06 19:20 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (9.00 KB, patch)
2012-05-15 12:28 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (12.63 KB, patch)
2012-05-15 12:32 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (12.56 KB, patch)
2012-05-23 09:03 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (12.56 KB, patch)
2012-05-24 07:24 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-05-06 19:20:19 PDT
Created attachment 140452 [details] Patch
WebKit Review Bot
Comment 2 2012-05-06 19:23:41 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2012-05-06 20:33:28 PDT
Comment on attachment 140452 [details] Patch Don't you need to update some GYP or GYPI files?
Mark Pilgrim (Google)
Comment 4 2012-05-15 12:28:44 PDT
Created attachment 142026 [details] Patch
Mark Pilgrim (Google)
Comment 5 2012-05-15 12:30:11 PDT
Comment on attachment 142026 [details] Patch Crap, missing a file still.
Mark Pilgrim (Google)
Comment 6 2012-05-15 12:32:19 PDT
Created attachment 142027 [details] Patch
Mark Pilgrim (Google)
Comment 7 2012-05-15 12:32:51 PDT
Comment on attachment 142027 [details] Patch Now with added GYP/GYPI files.
Adam Barth
Comment 8 2012-05-15 14:02:09 PDT
Comment on attachment 142027 [details] Patch I support this product and/or service.
WebKit Review Bot
Comment 9 2012-05-15 15:06:47 PDT
Comment on attachment 142027 [details] Patch Rejecting attachment 142027 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: file Source/WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file Source/WebKit/chromium/WebKit.gyp patching file Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h patching file Source/WebKit/chromium/public/platform/WebLocalizedString.h patching file Source/WebKit/chromium/src/LocalizedStrings.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12683876
Mark Pilgrim (Google)
Comment 10 2012-05-23 09:03:29 PDT
Created attachment 143579 [details] Patch
WebKit Review Bot
Comment 11 2012-05-23 11:52:43 PDT
Comment on attachment 143579 [details] Patch Clearing flags on attachment: 143579 Committed r118218: <http://trac.webkit.org/changeset/118218>
WebKit Review Bot
Comment 12 2012-05-23 11:52:48 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 13 2012-05-23 12:56:33 PDT
Re-opened since this is blocked by 87299
Mark Pilgrim (Google)
Comment 14 2012-05-24 07:24:27 PDT
Created attachment 143828 [details] Patch
Mark Pilgrim (Google)
Comment 15 2012-05-24 07:28:51 PDT
Comment on attachment 143828 [details] Patch Properly declare WebLocalizedString as a struct. Should fix clang compilation errors (not caught by EWS bots).
WebKit Review Bot
Comment 16 2012-05-24 09:28:40 PDT
Comment on attachment 143828 [details] Patch Clearing flags on attachment: 143828 Committed r118384: <http://trac.webkit.org/changeset/118384>
WebKit Review Bot
Comment 17 2012-05-24 09:28:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.