Bug 85754

Summary: Update vsprops files to include all ENABLE_ macros
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED LATER    
Severity: Normal CC: jberlin, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 85743    
Bug Blocks: 85456    
Attachments:
Description Flags
Patch rniwa: review+, webkit.review.bot: commit-queue-

Description Eric Seidel (no email) 2012-05-06 16:57:30 PDT
Update vsprops files to include all ENABLE_ macros
Comment 1 Eric Seidel (no email) 2012-05-06 17:03:12 PDT
Created attachment 140446 [details]
Patch
Comment 2 Ryosuke Niwa 2012-07-19 16:17:39 PDT
Comment on attachment 140446 [details]
Patch

rs=me.
Comment 3 Eric Seidel (no email) 2012-07-19 21:36:40 PDT
Comment on attachment 140446 [details]
Patch

I doubt this still applies.
Comment 4 WebKit Review Bot 2012-07-19 21:38:52 PDT
Comment on attachment 140446 [details]
Patch

Rejecting attachment 140446 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
set 25 lines).
Hunk #8 FAILED at 202.
Hunk #9 succeeded at 272 (offset 35 lines).
Hunk #10 succeeded at 297 (offset 35 lines).
Hunk #11 succeeded at 342 (offset 40 lines).
Hunk #12 succeeded at 397 (offset 50 lines).
2 out of 12 hunks FAILED -- saving rejects to file WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ryosuke Ni..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13317039
Comment 5 Eric Seidel (no email) 2013-01-04 01:58:22 PST
This would be nice to have, but I don't plan to clean this up and land it anytime soon.