Summary: | [WK2] Push wheel events if there are too many in queue | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||||
Component: | WebKit2 | Assignee: | Jon Lee <jonlee> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, mjs, sam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.7 | ||||||||
Attachments: |
|
Description
Jon Lee
2012-05-06 14:25:33 PDT
Created attachment 140435 [details]
Patch
Comment on attachment 140435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140435&action=review > Source/WebKit2/UIProcess/WebPageProxy.h:1031 > + class CoalescedWheelEvent : public RefCounted<CoalescedWheelEvent> { > + public: > + static PassRefPtr<CoalescedWheelEvent> create(); > + CoalescedWheelEvent(); > + virtual ~CoalescedWheelEvent(); > + Vector<NativeWebWheelEvent> events; > + }; Is it necessary for this whole class to be public? It seems like at the very least, the constructor should be private. I'm also not clear on why this needs to be RefCounted. Created attachment 140475 [details]
Patch
Comment on attachment 140475 [details]
Patch
Originally had some problems using just the Vector but figured it out! Got rid of the internal class.
Committed r116466: <http://trac.webkit.org/changeset/116466> |