Bug 85744

Summary: Update several build-webkit options to match the #defines they toggle
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Severity: Normal CC: abarth, dbates, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 53714    
Bug Blocks: 85456    
Description Flags
Patch none

Description Eric Seidel (no email) 2012-05-06 13:51:56 PDT
Update several build-webkit options to match the #defines they toggle
Comment 1 Eric Seidel (no email) 2012-05-06 13:53:12 PDT
Created attachment 140432 [details]
Comment 2 Eric Seidel (no email) 2012-05-06 13:55:12 PDT
Most of these defines are obscure enough that I don't believe we have any buildbots which depend on them.  Users will very quickly learn the right one if they've been passing them manually on the command line. ;)
Comment 3 Eric Seidel (no email) 2012-05-06 13:56:21 PDT
Bug 53714 is where the #define rename happened for 3D_CANVAS in build-webkit.  THis patch completes that work. :)
Comment 4 Adam Barth 2012-05-06 13:58:01 PDT
Comment on attachment 140432 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=140432&action=review

> Tools/Scripts/webkitperl/FeatureList.pm:225
> -      define => "ENABLE_JAVASCRIPT_DEBUGGER", default => 1, value => \$javaScriptDebuggerSupport },
> +      define => "ENABLE_JAVASCRIPT_DEBUGGER", default => 1, value => \$javascriptDebuggerSupport },

Comment 5 WebKit Review Bot 2012-05-06 17:13:53 PDT
Comment on attachment 140432 [details]

Clearing flags on attachment: 140432

Committed r116251: <http://trac.webkit.org/changeset/116251>
Comment 6 WebKit Review Bot 2012-05-06 17:13:57 PDT
All reviewed patches have been landed.  Closing bug.