Summary: | Update several build-webkit options to match the #defines they toggle | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dbates, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 53714 | ||||||
Bug Blocks: | 85456 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2012-05-06 13:51:56 PDT
Created attachment 140432 [details]
Patch
Most of these defines are obscure enough that I don't believe we have any buildbots which depend on them. Users will very quickly learn the right one if they've been passing them manually on the command line. ;) Bug 53714 is where the #define rename happened for 3D_CANVAS in build-webkit. THis patch completes that work. :) Comment on attachment 140432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140432&action=review > Tools/Scripts/webkitperl/FeatureList.pm:225 > - define => "ENABLE_JAVASCRIPT_DEBUGGER", default => 1, value => \$javaScriptDebuggerSupport }, > + define => "ENABLE_JAVASCRIPT_DEBUGGER", default => 1, value => \$javascriptDebuggerSupport }, :( Comment on attachment 140432 [details] Patch Clearing flags on attachment: 140432 Committed r116251: <http://trac.webkit.org/changeset/116251> All reviewed patches have been landed. Closing bug. |