WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
85744
Update several build-webkit options to match the #defines they toggle
https://bugs.webkit.org/show_bug.cgi?id=85744
Summary
Update several build-webkit options to match the #defines they toggle
Eric Seidel (no email)
Reported
2012-05-06 13:51:56 PDT
Update several build-webkit options to match the #defines they toggle
Attachments
Patch
(4.74 KB, patch)
2012-05-06 13:53 PDT
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2012-05-06 13:53:12 PDT
Created
attachment 140432
[details]
Patch
Eric Seidel (no email)
Comment 2
2012-05-06 13:55:12 PDT
Most of these defines are obscure enough that I don't believe we have any buildbots which depend on them. Users will very quickly learn the right one if they've been passing them manually on the command line. ;)
Eric Seidel (no email)
Comment 3
2012-05-06 13:56:21 PDT
Bug 53714
is where the #define rename happened for 3D_CANVAS in build-webkit. THis patch completes that work. :)
Adam Barth
Comment 4
2012-05-06 13:58:01 PDT
Comment on
attachment 140432
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=140432&action=review
> Tools/Scripts/webkitperl/FeatureList.pm:225 > - define => "ENABLE_JAVASCRIPT_DEBUGGER", default => 1, value => \$javaScriptDebuggerSupport }, > + define => "ENABLE_JAVASCRIPT_DEBUGGER", default => 1, value => \$javascriptDebuggerSupport },
:(
WebKit Review Bot
Comment 5
2012-05-06 17:13:53 PDT
Comment on
attachment 140432
[details]
Patch Clearing flags on attachment: 140432 Committed
r116251
: <
http://trac.webkit.org/changeset/116251
>
WebKit Review Bot
Comment 6
2012-05-06 17:13:57 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug