Bug 85741

Summary: Cleanup: Change boolean synchronous flag argument into enum in FileSystem API code
Product: WebKit Reporter: Kinuko Yasuda <kinuko>
Component: WebCore Misc.Assignee: Kinuko Yasuda <kinuko>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kinuko Yasuda
Reported 2012-05-06 11:02:17 PDT
Cleanup: Change boolean synchronous flag argument into enum in FileSystem API code As in general using boolean argument is discouraged in WebKit.
Attachments
Patch (19.97 KB, patch)
2012-05-06 11:06 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Patch (22.13 KB, patch)
2012-05-06 11:09 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1 2012-05-06 11:06:10 PDT
Created attachment 140426 [details] Patch
Kinuko Yasuda
Comment 2 2012-05-06 11:09:17 PDT
Created attachment 140427 [details] Patch
David Levin
Comment 3 2012-05-06 11:41:15 PDT
Comment on attachment 140427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140427&action=review > Source/WebCore/platform/FileSystemType.h:1 > +/* I'm surprised that there aren't some build file changes to go along with this. It would be nice to include it in build files. As long as this not being the those files doesn't break anything and it doesn't seem to, I would be fine with that as a follow up patch -- In fact I made this comment in the other patch so I'd land both and do one follow up patch for both of them :) (but no rush on that follow up patch).
Kinuko Yasuda
Comment 4 2012-05-07 01:56:56 PDT
Committed r116283: <http://trac.webkit.org/changeset/116283>
Kinuko Yasuda
Comment 5 2012-05-07 02:03:53 PDT
Comment on attachment 140427 [details] Patch Will create a follow-up patch for adding the header file to build/make files.
Note You need to log in before you can comment on or make changes to this bug.