Summary: | Web Inspector: do not create locations for resolved provisional breakpoints | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Feldman
2012-05-05 09:21:59 PDT
Created attachment 140405 [details]
Patch
Created attachment 140409 [details]
Patch
Comment on attachment 140409 [details]
Patch
looks good!
Comment on attachment 140409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140409&action=review > Source/WebCore/inspector/front-end/BreakpointManager.js:157 > + breakpoints[i]._isProvisional = true; Where is this flag reset? Comment on attachment 140409 [details]
Patch
It is not reset, it dies along with the breakpoint object when provisional breakpoints are cleared.
Comment on attachment 140409 [details] Patch Clearing flags on attachment: 140409 Committed r116397: <http://trac.webkit.org/changeset/116397> All reviewed patches have been landed. Closing bug. |