Bug 85716

Summary: Web Inspector: do not create locations for resolved provisional breakpoints
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Pavel Feldman
Reported 2012-05-05 09:21:59 PDT
Internal design, patch to follow.
Attachments
Patch (2.25 KB, patch)
2012-05-05 09:25 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (6.97 KB, patch)
2012-05-05 09:56 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-05-05 09:25:59 PDT
Created attachment 140405 [details] Patch
Pavel Feldman
Comment 2 2012-05-05 09:56:21 PDT
Created attachment 140409 [details] Patch
Pavel Podivilov
Comment 3 2012-05-05 09:57:59 PDT
Comment on attachment 140409 [details] Patch looks good!
Yury Semikhatsky
Comment 4 2012-05-05 23:41:04 PDT
Comment on attachment 140409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140409&action=review > Source/WebCore/inspector/front-end/BreakpointManager.js:157 > + breakpoints[i]._isProvisional = true; Where is this flag reset?
Pavel Feldman
Comment 5 2012-05-07 23:26:21 PDT
Comment on attachment 140409 [details] Patch It is not reset, it dies along with the breakpoint object when provisional breakpoints are cleared.
Pavel Feldman
Comment 6 2012-05-07 23:29:57 PDT
Comment on attachment 140409 [details] Patch Clearing flags on attachment: 140409 Committed r116397: <http://trac.webkit.org/changeset/116397>
Pavel Feldman
Comment 7 2012-05-07 23:30:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.