Bug 85707

Summary:

Web Inspector: take timeline frame mode out of experimental

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+

Andrey Kosyakov

Reported 2012-05-05 05:48:02 PDT

- Remove "Vertical timeline overview" experiment; - Add supportsFrameInstrumentation capability to InspectorTimelineAgent; - Show frame mode selector conditionally on supportsFrameInstrumentation capability.

Attachments
Patch (15.98 KB, patch) 2012-05-05 05:56 PDT, Andrey Kosyakov	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2012-05-05 05:56:29 PDT

Created attachment 140395 [details] Patch

Pavel Feldman

Comment 2 2012-05-05 08:36:38 PDT

Comment on attachment 140395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140395&action=review > Source/WebCore/inspector/InspectorController.cpp:115 > + m_agents.append(InspectorTimelineAgent::create(m_instrumentingAgents.get(), m_state.get(), InspectorTimelineAgent::PageInspector, You make inspector controller timeline-details-aware. You should instead create a stub for worker's InspectorClient.

Andrey Kosyakov

Comment 3 2012-05-06 07:53:48 PDT

Committed r116237: <http://trac.webkit.org/changeset/116237>

Note You need to log in before you can comment on or make changes to this bug.