Bug 85697

Summary: webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: Tools / TestsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric: review+

Raphael Kubo da Costa (:rakuco)
Reported 2012-05-04 22:41:22 PDT
webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
Attachments
Patch (1.71 KB, patch)
2012-05-04 22:43 PDT, Raphael Kubo da Costa (:rakuco) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-05-04 22:43:01 PDT
Created attachment 140381 [details] Patch
Eric Seidel (no email)
Comment 2 2012-05-05 10:56:04 PDT
Comment on attachment 140381 [details] Patch Yay! Except we really should have an os abstraction if this were unittested code (which some day it should be). I believe FileSystem has .sep, so presumably eventually our FileSystem class will have pathsep. Since this is not currently really unittestable code, I won't make you move it. But some day we should. :)
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-05-05 14:08:12 PDT
Committed r116229: <http://trac.webkit.org/changeset/116229>
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-05-05 14:09:11 PDT
(In reply to comment #2) > (From update of attachment 140381 [details]) > Yay! Except we really should have an os abstraction if this were unittested code (which some day it should be). I believe FileSystem has .sep, so presumably eventually our FileSystem class will have pathsep. > > Since this is not currently really unittestable code, I won't make you move it. But some day we should. :) I've filed https://bugs.webkit.org/show_bug.cgi?id=85720 for that :-)
Note You need to log in before you can comment on or make changes to this bug.