Bug 85692 – Convert isPageBoxVisible to use Internals interface

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Gyuyoung Kim]

Adjust isPageBoxVisible tests to use Internals instead of LayoutTestController interface. In my humble opinion, isPageBoxVisible() is able to be supported by Internals. Because, it looks this function is implemented by WebCore layer, not WebKit layer. I'd like to know how do reviewers think about this patch.

[Gyuyoung Kim]

Created attachment 140379 [details]
Patch

[Early Warning System Bot]

Comment on attachment 140379 [details]
Patch

Attachment 140379 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12626348

[WebKit Review Bot]

Comment on attachment 140379 [details]
Patch

Attachment 140379 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12543527

[Build Bot]

Comment on attachment 140379 [details]
Patch

Attachment 140379 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12602355

[Build Bot]

Comment on attachment 140379 [details]
Patch

Attachment 140379 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12531360

[Early Warning System Bot]

Comment on attachment 140379 [details]
Patch

Attachment 140379 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12626362

[Gyuyoung Kim]

Created attachment 140382 [details]
Patch

[Build Bot]

Comment on attachment 140382 [details]
Patch

Attachment 140382 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12507439

[Gyuyoung Kim]

Created attachment 140397 [details]
Patch

[Darin Adler]

Comment on attachment 140397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140397&action=review

> Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm:-315
> -    return [mainFrame isPageBoxVisible:pageNumber];

I can’t speak for the other ports, but for the Mac port, the isPageBoxVisible: method exists only to support this DumpRenderTree feature. So we should also be removing that method from WebKit entirely.

[WebKit Review Bot]

Comment on attachment 140397 [details]
Patch

Clearing flags on attachment: 140397

Committed r116246: <http://trac.webkit.org/changeset/116246>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Andy Estes]

This patch broke the build on my machine due to leaving behind an unused function. I removed the function in <http://trac.webkit.org/changeset/116252>.

[Gyuyoung Kim]

(In reply to comment #13)
> This patch broke the build on my machine due to leaving behind an unused function. I removed the function in <http://trac.webkit.org/changeset/116252>.

Thank you for your fix for build break.