Bug 85688

Summary: Rename ICULocale to LocaleICU, part 1
Product: WebKit Reporter: Kent Tamura <tkent>
Component: PlatformAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85695    
Attachments:
Description Flags
Patch haraken: review+

Kent Tamura
Reported 2012-05-04 18:22:10 PDT
Rename ICULocale to LocaleICU, part 1
Attachments
Patch (46.03 KB, patch)
2012-05-04 18:33 PDT, Kent Tamura 		haraken: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-05-04 18:33:22 PDT
Created attachment 140372 [details] Patch
WebKit Review Bot
Comment 2 2012-05-04 18:38:23 PDT
Attachment 140372 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/text/LocaleICU.h:31: #ifndef header guard has wrong style, please use: LocaleICU_h [build/header_guard] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kentaro Hara
Comment 3 2012-05-04 19:41:44 PDT
Comment on attachment 140372 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140372&action=review > Source/WebCore/ChangeLog:8 > + Rename it for consistency. Our convension is Foo<Platform>.{cpp,h}. Nit: convention > Source/WebCore/WebCore.gypi:4489 > + 'platform/text/LocaleICU.cpp', > + 'platform/text/LocaleICU.h', Nit: Alphabetical order please.
Kent Tamura
Comment 4 2012-05-04 19:48:59 PDT
Comment on attachment 140372 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140372&action=review Thanks! >> Source/WebCore/ChangeLog:8 >> + Rename it for consistency. Our convension is Foo<Platform>.{cpp,h}. > > Nit: convention oops >> Source/WebCore/WebCore.gypi:4489 >> + 'platform/text/LocaleICU.h', > > Nit: Alphabetical order please. Will fix.
Kent Tamura
Comment 5 2012-05-04 19:53:23 PDT
Committed r116204: <http://trac.webkit.org/changeset/116204>
Note You need to log in before you can comment on or make changes to this bug.