Bug 85688

Summary: Rename ICULocale to LocaleICU, part 1
Product: WebKit Reporter: Kent Tamura <tkent@chromium.org>
Component: PlatformAssignee: Kent Tamura <tkent@chromium.org>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken@chromium.org, morrita@google.com, webkit.review.bot@gmail.com
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85695    
Attachments:
Description Flags
Patch haraken: review+

Description From 2012-05-04 18:22:10 PST
Rename ICULocale to LocaleICU, part 1
------- Comment #1 From 2012-05-04 18:33:22 PST -------
Created an attachment (id=140372) [details]
Patch
------- Comment #2 From 2012-05-04 18:38:23 PST -------
Attachment 140372 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/text/LocaleICU.h:31:  #ifndef header guard has wrong style, please use: LocaleICU_h  [build/header_guard] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #3 From 2012-05-04 19:41:44 PST -------
(From update of attachment 140372 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=140372&action=review

> Source/WebCore/ChangeLog:8
> +        Rename it for consistency. Our convension is Foo<Platform>.{cpp,h}.

Nit: convention

> Source/WebCore/WebCore.gypi:4489
> +            'platform/text/LocaleICU.cpp',
> +            'platform/text/LocaleICU.h',

Nit: Alphabetical order please.
------- Comment #4 From 2012-05-04 19:48:59 PST -------
(From update of attachment 140372 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=140372&action=review

Thanks!

>> Source/WebCore/ChangeLog:8
>> +        Rename it for consistency. Our convension is Foo<Platform>.{cpp,h}.
> 
> Nit: convention

oops

>> Source/WebCore/WebCore.gypi:4489
>> +            'platform/text/LocaleICU.h',
> 
> Nit: Alphabetical order please.

Will fix.
------- Comment #5 From 2012-05-04 19:53:23 PST -------
Committed r116204: <http://trac.webkit.org/changeset/116204>