Bug 85644

Summary: [chromium] Revert compositor layer scrolling
Product: WebKit Reporter: Sami Kyostila <skyostil>
Component: New BugsAssignee: Sami Kyostila <skyostil>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, cc-bugs, jamesr, nduca, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Sami Kyostila 2012-05-04 10:53:06 PDT
[chromium] Revert compositor layer scrolling
Comment 1 Sami Kyostila 2012-05-04 10:54:48 PDT
Created attachment 140275 [details]
Patch
Comment 2 Andrei Popescu 2012-05-04 11:02:27 PDT
LGTM...really sorry to see this reverted. Let's reland as soon as the crashers are fixed.
Comment 3 Steve Block 2012-05-04 11:05:18 PDT
Comment on attachment 140275 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140275&action=review

rubber stamp

> Source/WebCore/ChangeLog:9
> +        trigger crashes:

Is there a bug which discusses this which you can link to?

> Source/WebCore/ChangeLog:13
> +            [chromium] Don't keep pointers to released layer tree

Please link to the revisions.
Comment 4 Sami Kyostila 2012-05-04 11:18:42 PDT
Created attachment 140281 [details]
Patch
Comment 5 Sami Kyostila 2012-05-04 11:20:51 PDT
I've improved the Changelog entry. Another look please?
Comment 6 Steve Block 2012-05-04 11:21:02 PDT
Comment on attachment 140281 [details]
Patch

rubber stamp
Comment 7 WebKit Review Bot 2012-05-04 12:25:16 PDT
Comment on attachment 140281 [details]
Patch

Clearing flags on attachment: 140281

Committed r116142: <http://trac.webkit.org/changeset/116142>
Comment 8 WebKit Review Bot 2012-05-04 12:25:21 PDT
All reviewed patches have been landed.  Closing bug.