Bug 8564

Summary:

crashed when closing a tab

Product:

WebKit

Reporter:

tim bates <timothy.c.bates>

Component:

New Bugs

Assignee:

Tim Omernick <timo>

Status:

RESOLVED FIXED

Severity:

Critical

CC:

mitz, timo

Priority:

Keywords:

InRadar, Regression

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Patch to more clearly define Netscape plug-in view teardown	darin: review-
Patch to address Darin's comments	ggaren: review+

tim bates

Reported 2006-04-24 04:09:25 PDT

Date/Time: 2006-04-24 12:07:46.081 +0100 OS Version: 10.4.6 (Build 8I127) Report Version: 4 Command: Safari Path: /Applications/Safari.app/Contents/MacOS/Safari Parent: WindowServer [68] Version: ??? (14032) PID: 25986 Thread: 0 Exception: EXC_BAD_ACCESS (0x0001) Codes: KERN_INVALID_ADDRESS (0x0001) at 0x208ba008 Thread 0 Crashed: 0 <<00000000>> 0xfffeff30 objc_msgSend_rtp + 48 1 com.apple.WebKit 0x00314bb0 -[WebBaseNetscapePluginView webFrame] + 32 2 com.apple.WebKit 0x00314bf0 -[WebBaseNetscapePluginView webView] + 32 3 com.apple.WebKit 0x00315504 -[WebBaseNetscapePluginView viewWillMoveToWindow:] + 116 4 com.apple.AppKit 0x9373af64 -[NSView _setWindow:] + 60 5 com.apple.AppKit 0x9373a710 -[NSView removeFromSuperview] + 292 6 com.apple.WebCore 0x01268d04 WebCore::Widget::removeFromSuperview() + 260 7 com.apple.WebCore 0x011ed79c WebCore::RenderWidget::destroy() + 92 8 com.apple.WebCore 0x0129b608 WebCore::Node::detach() + 72 9 com.apple.WebCore 0x01124a68 WebCore::ContainerNode::detach() + 72 10 com.apple.WebCore 0x01124a68 WebCore::ContainerNode::detach() + 72 11 com.apple.WebCore 0x01124a68 WebCore::ContainerNode::detach() + 72 12 com.apple.WebCore 0x01124a68 WebCore::ContainerNode::detach() + 72 13 com.apple.WebCore 0x01124a68 WebCore::ContainerNode::detach() + 72 14 com.apple.WebCore 0x01124a68 WebCore::ContainerNode::detach() + 72 15 com.apple.WebCore 0x01124a68 WebCore::ContainerNode::detach() + 72 16 com.apple.WebCore 0x01124a68 WebCore::ContainerNode::detach() + 72 17 com.apple.WebCore 0x0111b788 WebCore::Document::detach() + 360 18 com.apple.WebCore 0x01105604 WebCore::FrameMac::setView(WebCore::FrameView*) + 100 19 com.apple.WebCore 0x011fd938 WebCore::Page::~Page [in-charge]() + 56 20 com.apple.WebCore 0x01133940 -[WebCorePageBridge dealloc] + 48 21 com.apple.WebKit 0x0035ec38 -[WebView(WebPrivate) _close] + 120 22 com.apple.Safari 0x00047d80 0x1000 + 290176 23 com.apple.Safari 0x00047c24 0x1000 + 289828 24 com.apple.Safari 0x00047bb8 0x1000 + 289720 25 com.apple.Safari 0x000719ec 0x1000 + 461292 26 com.apple.AppKit 0x937c1270 -[NSApplication sendAction:to:from:] + 108 27 com.apple.Safari 0x00029b5c 0x1000 + 166748 28 com.apple.AppKit 0x9381baa4 -[NSMenu performActionForItemAtIndex:] + 392 29 com.apple.AppKit 0x9381b828 -[NSCarbonMenuImpl performActionWithHighlightingForItemAtIndex:] + 104 30 com.apple.AppKit 0x9381b2d0 -[NSMenu performKeyEquivalent:] + 272 31 com.pozytron.AcidSearch 0x0163966c -[PZTypeAheadController performKeyEquivalent:] + 116 (bundle1.s:283) 32 com.pozytron.AcidSearch 0x01632754 -[BrowserWindowController(PZ) pzPerformKeyEquivalent:] + 64 (bundle1.s:283) 33 com.apple.Safari 0x00029384 0x1000 + 164740 34 com.apple.AppKit 0x9381ae0c -[NSApplication _handleKeyEquivalent:] + 56 35 com.apple.AppKit 0x93724a28 -[NSApplication sendEvent:] + 2944 36 com.apple.Safari 0x00021828 0x1000 + 133160 37 com.apple.AppKit 0x9371c330 -[NSApplication run] + 508 38 com.apple.AppKit 0x9380ce68 NSApplicationMain + 452 39 com.apple.Safari 0x0005cbec 0x1000 + 375788 40 com.apple.Safari 0x0005ca94 0x1000 + 375444 Thread 1: 0 libSystem.B.dylib 0x9000b0a8 mach_msg_trap + 8 1 libSystem.B.dylib 0x9000affc mach_msg + 60 2 com.apple.CoreFoundation 0x907e4114 __CFRunLoopRun + 832 3 com.apple.CoreFoundation 0x907e3a18 CFRunLoopRunSpecific + 268 4 com.apple.Foundation 0x92985164 -[NSRunLoop runMode:beforeDate:] + 172 5 com.apple.Foundation 0x9298509c -[NSRunLoop run] + 76 6 com.apple.WebKit 0x0036ce74 +[WebFileDatabase _syncLoop:] + 180 7 com.apple.Foundation 0x92976194 forkThreadForFunction + 108 8 libSystem.B.dylib 0x9002ba68 _pthread_body + 96 Thread 2: 0 libSystem.B.dylib 0x9000b0a8 mach_msg_trap + 8 1 libSystem.B.dylib 0x9000affc mach_msg + 60 2 com.apple.CoreFoundation 0x907e4114 __CFRunLoopRun + 832 3 com.apple.CoreFoundation 0x907e3a18 CFRunLoopRunSpecific + 268 4 com.apple.Foundation 0x9299d69c +[NSURLConnection(NSURLConnectionInternal) _resourceLoadLoop:] + 264 5 com.apple.Foundation 0x92976194 forkThreadForFunction + 108 6 libSystem.B.dylib 0x9002ba68 _pthread_body + 96 Thread 3: 0 libSystem.B.dylib 0x9000b0a8 mach_msg_trap + 8 1 libSystem.B.dylib 0x9000affc mach_msg + 60 2 com.apple.CoreFoundation 0x907e4114 __CFRunLoopRun + 832 3 com.apple.CoreFoundation 0x907e3a18 CFRunLoopRunSpecific + 268 4 com.apple.Foundation 0x9299e7dc +[NSURLCache _diskCacheSyncLoop:] + 152 5 com.apple.Foundation 0x92976194 forkThreadForFunction + 108 6 libSystem.B.dylib 0x9002ba68 _pthread_body + 96 Thread 4: 0 libSystem.B.dylib 0x9002c128 semaphore_wait_signal_trap + 8 1 libSystem.B.dylib 0x90030bec pthread_cond_wait + 480 2 com.apple.Foundation 0x9297d300 -[NSConditionLock lockWhenCondition:] + 68 3 com.apple.Syndication 0x99f7150c -[AsyncDB _run:] + 192 4 com.apple.Foundation 0x92976194 forkThreadForFunction + 108 5 libSystem.B.dylib 0x9002ba68 _pthread_body + 96 Thread 5: 0 libSystem.B.dylib 0x9001f5ec select + 12 1 com.apple.CoreFoundation 0x907f69a8 __CFSocketManager + 472 2 libSystem.B.dylib 0x9002ba68 _pthread_body + 96 Thread 6: 0 libSystem.B.dylib 0x9002c128 semaphore_wait_signal_trap + 8 1 libSystem.B.dylib 0x90030bec pthread_cond_wait + 480 2 com.apple.ColorSync 0x915d3224 pthreadSemaphoreWait(t_pthreadSemaphore*) + 56 3 com.apple.ColorSync 0x915d24c0 CMMConvTask(void*) + 40 4 libSystem.B.dylib 0x9002ba68 _pthread_body + 96 Thread 0 crashed with PPC Thread State 64: srr0: 0x00000000fffeff30 srr1: 0x100000000000f030 vrsave: 0x0000000000000000 cr: 0x44002242 xer: 0x0000000020000000 lr: 0x0000000000314bb0 ctr: 0x0000000000319810 r0: 0x00000000906b9570 r1: 0x00000000bfffd870 r2: 0x00000000906b9568 r3: 0x00000000142a5000 r4: 0x0000000090a93adc r5: 0x0000000000000000 r6: 0x0000000000000000 r7: 0x0000000000000000 r8: 0x01d6e3f31b00c858 r9: 0x0000000090200a98 r10: 0x00000000a07c1b8c r11: 0x00000000f0200a98 r12: 0x00000000a0395ecc r13: 0x0000000000000000 r14: 0x0000000000000000 r15: 0x0000000000000000 r16: 0x0000000000000000 r17: 0x0000000000000000 r18: 0x0000000000000000 r19: 0x0000000000000000 r20: 0x0000000000000000 r21: 0x0000000000000000 r22: 0x0000000000000000 r23: 0x0000000000000000 r24: 0x00000000000aedcc r25: 0x00000000005337a0 r26: 0x00000000a375af28 r27: 0x0000000000000000 r28: 0x0000000016b91310 r29: 0x0000000000000000 r30: 0x0000000016890530 r31: 0x0000000000314b90 Binary Images Description: 0x1000 - 0xdafff com.apple.Safari 2.0.3 (417.9.2) /Applications/Safari.app/Contents/MacOS/Safari 0x106000 - 0x106fff WebKitNightlyEnabler.dylib /Applications/WebKit.app/Contents/Resources/WebKitNightlyEnabler.dylib 0x109000 - 0x195fff com.apple.JavaScriptCore 420+ /Applications/WebKit.app/Contents/Resources/JavaScriptCore.framework/Versions/A/JavaScriptCore 0x305000 - 0x3b0fff com.apple.WebKit 420+ /Applications/WebKit.app/Contents/Resources/WebKit.framework/Versions/A/WebKit 0x1008000 - 0x1375fff com.apple.WebCore 420+ /Applications/WebKit.app/Contents/Resources/WebCore.framework/Versions/A/WebCore 0x1550000 - 0x1552fff net.culater.SIMBL 0.8 (8) /Users/tim/Library/InputManagers/SIMBL/SIMBL.bundle/Contents/MacOS/SIMBL 0x15d6000 - 0x15ddfff com.unsanity.smartcrashreports Smart Crash Reports version 1.0.2 (1.0.2) /Users/tim/Library/InputManagers/Smart Crash Reports/Smart Crash Reports.bundle/Contents/MacOS/Smart Crash Reports 0x15e2000 - 0x15e5fff com.macromates.edit_in_textmate ??? (1.0) /Applications/TextMate/TextMate.app/Contents/Resources/Edit in TextMate/Edit in TextMate.bundle/Contents/MacOS/Edit in TextMate 0x1624000 - 0x1643fff com.pozytron.AcidSearch 0.62 /Users/tim/Library/Application Support/SIMBL/Plugins/AcidSearch.bundle/Contents/MacOS/AcidSearch 0x16c05000 - 0x16df5fff com.macromedia.Flash Player.plugin 8.0.24 (1.0.1f24) /Library/Internet Plug-Ins/Flash Player.plugin/Contents/MacOS/Flash Player 0x8fa79000 - 0x8fd27fff com.apple.QuickTime 7.0.4 /System/Library/Frameworks/QuickTime.framework/Versions/A/QuickTime 0x8fe00000 - 0x8fe51fff dyld 44.4 /usr/lib/dyld 0x90000000 - 0x901bbfff libSystem.B.dylib /usr/lib/libSystem.B.dylib 0x90213000 - 0x90218fff libmathCommon.A.dylib /usr/lib/system/libmathCommon.A.dylib 0x9021a000 - 0x9026dfff com.apple.CoreText 1.0.1 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreText.framework/Versions/A/CoreText 0x9029a000 - 0x9034bfff ATS /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS 0x9037a000 - 0x90734fff com.apple.CoreGraphics 1.258.27 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics 0x907c1000 - 0x9089afff com.apple.CoreFoundation 6.4.4 (368.25) /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation 0x908e3000 - 0x908e3fff com.apple.CoreServices 10.4 (???) /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices 0x908e5000 - 0x909e7fff libicucore.A.dylib /usr/lib/libicucore.A.dylib 0x90a41000 - 0x90ac5fff libobjc.A.dylib /usr/lib/libobjc.A.dylib 0x90aef000 - 0x90b5dfff com.apple.framework.IOKit 1.4 (???) /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit 0x90b74000 - 0x90b86fff libauto.dylib /usr/lib/libauto.dylib 0x90b8d000 - 0x90e65fff com.apple.CoreServices.CarbonCore 681.3 (671.2) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore 0x90ecb000 - 0x90f4bfff com.apple.CoreServices.OSServices 4.1 /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices 0x90f95000 - 0x90fd6fff com.apple.CFNetwork 129.13 /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork 0x90feb000 - 0x91003fff com.apple.WebServices 1.1.2 (1.1.0) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/WebServicesCore.framework/Versions/A/WebServicesCore 0x91013000 - 0x91094fff com.apple.SearchKit 1.0.5 /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit 0x910da000 - 0x91104fff com.apple.Metadata 10.4.4 (121.36) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata 0x91115000 - 0x91123fff libz.1.dylib /usr/lib/libz.1.dylib 0x91126000 - 0x912e9fff com.apple.security 4.3 (25966) /System/Library/Frameworks/Security.framework/Versions/A/Security 0x913ec000 - 0x913f5fff com.apple.DiskArbitration 2.1 /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration 0x913fc000 - 0x91423fff com.apple.SystemConfiguration 1.8.2 /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration 0x91436000 - 0x91441fff libgcc_s.1.dylib /usr/lib/libgcc_s.1.dylib 0x91446000 - 0x91466fff libmx.A.dylib /usr/lib/libmx.A.dylib 0x9146c000 - 0x91474fff libbsm.dylib /usr/lib/libbsm.dylib 0x91478000 - 0x914f3fff com.apple.audio.CoreAudio 3.0.3 /System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio 0x91530000 - 0x91530fff com.apple.ApplicationServices 10.4 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices 0x91532000 - 0x9156afff com.apple.AE 1.5 (297) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE 0x91585000 - 0x91652fff com.apple.ColorSync 4.4.4 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSync.framework/Versions/A/ColorSync 0x916a7000 - 0x91738fff com.apple.print.framework.PrintCore 4.5 (177.10) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore 0x9177f000 - 0x91836fff com.apple.QD 3.8.19 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD 0x91873000 - 0x918d1fff com.apple.HIServices 1.5.1 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices 0x918ff000 - 0x91923fff com.apple.LangAnalysis 1.6.1 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis 0x91937000 - 0x9195cfff com.apple.FindByContent 1.5 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/FindByContent.framework/Versions/A/FindByContent 0x9196f000 - 0x919b1fff com.apple.LaunchServices 168.10 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices 0x919cd000 - 0x919e1fff com.apple.speech.synthesis.framework 3.3 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis 0x919ef000 - 0x91a2efff com.apple.ImageIO.framework 1.4.6 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/ImageIO 0x91a44000 - 0x91b0cfff libcrypto.0.9.7.dylib /usr/lib/libcrypto.0.9.7.dylib 0x91b5a000 - 0x91b6ffff libcups.2.dylib /usr/lib/libcups.2.dylib 0x91b74000 - 0x91b91fff libJPEG.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libJPEG.dylib 0x91b96000 - 0x91c05fff libJP2.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libJP2.dylib 0x91c1c000 - 0x91c20fff libGIF.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libGIF.dylib 0x91c22000 - 0x91c69fff libRaw.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libRaw.dylib 0x91c6e000 - 0x91cabfff libTIFF.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libTIFF.dylib 0x91cb2000 - 0x91ccbfff libPng.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib 0x91cd0000 - 0x91cd3fff libRadiance.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libRadiance.dylib 0x91cd5000 - 0x91cd5fff com.apple.Accelerate 1.2.1 (Accelerate 1.2.1) /System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate 0x91cd7000 - 0x91db7fff com.apple.vImage 2.3 /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/vImage 0x91dbf000 - 0x91ddefff com.apple.Accelerate.vecLib 3.2.1 (vecLib 3.2.1) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/vecLib 0x91e4a000 - 0x91eb8fff libvMisc.dylib /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvMisc.dylib 0x91ec3000 - 0x91f57fff libvDSP.dylib /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvDSP.dylib 0x91f71000 - 0x924f9fff libBLAS.dylib /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib 0x9252c000 - 0x92857fff libLAPACK.dylib /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLAPACK.dylib 0x92887000 - 0x9290ffff com.apple.DesktopServices 1.3.3 /System/Library/PrivateFrameworks/DesktopServicesPriv.framework/Versions/A/DesktopServicesPriv 0x92950000 - 0x92b7bfff com.apple.Foundation 6.4.5 (567.26) /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation 0x92c99000 - 0x92d77fff libxml2.2.dylib /usr/lib/libxml2.2.dylib 0x92d97000 - 0x92e85fff libiconv.2.dylib /usr/lib/libiconv.2.dylib 0x92e97000 - 0x92eb5fff libGL.dylib /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib 0x92ec0000 - 0x92f1afff libGLU.dylib /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib 0x92f38000 - 0x92f38fff com.apple.Carbon 10.4 (???) /System/Library/Frameworks/Carbon.framework/Versions/A/Carbon 0x92f3a000 - 0x92f4efff com.apple.ImageCapture 3.0 /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture 0x92f66000 - 0x92f76fff com.apple.speech.recognition.framework 3.4 /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition 0x92f82000 - 0x92f97fff com.apple.securityhi 2.0 (203) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI 0x92fa9000 - 0x93030fff com.apple.ink.framework 101.2 (69) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink 0x93044000 - 0x9304ffff com.apple.help 1.0.3 (32) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help 0x93059000 - 0x93086fff com.apple.openscripting 1.2.5 (???) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting 0x930a0000 - 0x930b0fff com.apple.print.framework.Print 5.0 (190.1) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print 0x930bc000 - 0x93122fff com.apple.htmlrendering 1.1.2 /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HTMLRendering.framework/Versions/A/HTMLRendering 0x93153000 - 0x931a2fff com.apple.NavigationServices 3.4.4 (3.4.3) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/NavigationServices.framework/Versions/A/NavigationServices 0x931d0000 - 0x931edfff com.apple.audio.SoundManager 3.9 /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CarbonSound.framework/Versions/A/CarbonSound 0x931ff000 - 0x9320cfff com.apple.CommonPanels 1.2.2 (73) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels 0x93215000 - 0x93522fff com.apple.HIToolbox 1.4.6 (???) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox 0x93671000 - 0x9367dfff com.apple.opengl 1.4.7 /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL 0x93682000 - 0x936a2fff com.apple.DirectoryService.Framework 3.1 /System/Library/Frameworks/DirectoryService.framework/Versions/A/DirectoryService 0x93716000 - 0x93716fff com.apple.Cocoa 6.4 (???) /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa 0x93718000 - 0x93d4bfff com.apple.AppKit 6.4.4 (824.33) /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x940d8000 - 0x94148fff com.apple.CoreData 80 /System/Library/Frameworks/CoreData.framework/Versions/A/CoreData 0x94181000 - 0x9424bfff com.apple.audio.toolbox.AudioToolbox 1.4.1 /System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox 0x9429f000 - 0x9429ffff com.apple.audio.units.AudioUnit 1.4 /System/Library/Frameworks/AudioUnit.framework/Versions/A/AudioUnit 0x942a1000 - 0x94455fff com.apple.QuartzCore 1.4.7 /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore 0x944a8000 - 0x944e5fff libsqlite3.0.dylib /usr/lib/libsqlite3.0.dylib 0x944ed000 - 0x9453dfff libGLImage.dylib /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLImage.dylib 0x945cd000 - 0x94605fff com.apple.vmutils 4.0.0 (85) /System/Library/PrivateFrameworks/vmutils.framework/Versions/A/vmutils 0x94648000 - 0x94664fff com.apple.securityfoundation 2.1 (24988) /System/Library/Frameworks/SecurityFoundation.framework/Versions/A/SecurityFoundation 0x94678000 - 0x946bcfff com.apple.securityinterface 2.1 (24981) /System/Library/Frameworks/SecurityInterface.framework/Versions/A/SecurityInterface 0x946e0000 - 0x946effff libCGATS.A.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCGATS.A.dylib 0x946f7000 - 0x94703fff libCSync.A.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCSync.A.dylib 0x94749000 - 0x94761fff libRIP.A.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libRIP.A.dylib 0x94768000 - 0x947d9fff libstdc++.6.dylib /usr/lib/libstdc++.6.dylib 0x9494e000 - 0x94a7cfff com.apple.AddressBook.framework 4.0.3 (483) /System/Library/Frameworks/AddressBook.framework/Versions/A/AddressBook 0x94b0e000 - 0x94b1dfff com.apple.DSObjCWrappers.Framework 1.1 /System/Library/PrivateFrameworks/DSObjCWrappers.framework/Versions/A/DSObjCWrappers 0x94b25000 - 0x94b52fff com.apple.LDAPFramework 1.4.1 (69.0.1) /System/Library/Frameworks/LDAP.framework/Versions/A/LDAP 0x94b59000 - 0x94b69fff libsasl2.2.dylib /usr/lib/libsasl2.2.dylib 0x94b6d000 - 0x94b9cfff libssl.0.9.7.dylib /usr/lib/libssl.0.9.7.dylib 0x94bac000 - 0x94bc9fff libresolv.9.dylib /usr/lib/libresolv.9.dylib 0x95dce000 - 0x95df7fff libxslt.1.dylib /usr/lib/libxslt.1.dylib 0x978e0000 - 0x978edfff com.apple.agl 2.5.6 (AGL-2.5.6) /System/Library/Frameworks/AGL.framework/Versions/A/AGL 0x99f6e000 - 0x99fa4fff com.apple.Syndication 1.0.5 (52) /System/Library/PrivateFrameworks/Syndication.framework/Versions/A/Syndication 0x99fc1000 - 0x99fd3fff com.apple.SyndicationUI 1.0.5 (52) /System/Library/PrivateFrameworks/SyndicationUI.framework/Versions/A/SyndicationUI

Attachments
Patch to more clearly define Netscape plug-in view teardown (8.27 KB, patch) 2006-04-26 01:11 PDT, Tim Omernick	darin: review-	Details Formatted Diff Diff
Patch to address Darin's comments (5.66 KB, patch) 2006-04-26 12:40 PDT, Tim Omernick	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tim Omernick

Comment 1 2006-04-24 09:22:51 PDT

I wonder if, like 8567, this is caused by the fix for 8562.

Tim Omernick

Comment 2 2006-04-24 17:18:34 PDT

This is in Radar as 4525354.

Darin Adler

Comment 3 2006-04-25 08:45:03 PDT

And now as 4525105.

Darin Adler

Comment 4 2006-04-25 09:11:48 PDT

(In reply to comment #3) > And now as 4525105. Sorry, my mistake. These have been marked as duplicates in Radar, which is how I got confused.

Tim Omernick

Comment 5 2006-04-26 01:11:05 PDT

Created attachment 7969 [details] Patch to more clearly define Netscape plug-in view teardown

Tim Omernick

Comment 6 2006-04-26 01:13:16 PDT

*** Bug 8567 has been marked as a duplicate of this bug. ***

Tim Omernick

Comment 7 2006-04-26 01:17:18 PDT

I attached a patch which fixes this bug, as well as 8567. The problem was that Maciej's recent change to remove needless dependency on the view hieararchy (8562) exposed a design flaw in the Netscape plug-in code. Netscape plug-in views did not formerly have a well-defined teardown path; instead, they were relying on being removed from the view hierarchy and deallocated at just the right time. My patch makes WebFrame keep track of its plug-in views, and invalidate them when the page is about to be torn down.

Darin Adler

Comment 8 2006-04-26 08:11:50 PDT

Comment on attachment 7969 [details] Patch to more clearly define Netscape plug-in view teardown + NSEnumerator *plugInViewEnumerator = [_private->plugInViews objectEnumerator]; + NSView *plugInView; + while ((plugInView = [plugInViewEnumerator nextObject]) != nil) + [plugInView setWebFrame:nil]; How about [_private->plugInViews makeObjectsPerformSelector:@selector(setWebFrame:) withObject:nil] for this? + Noticed a little bit of funny logic here. We should stop the plug-in when it is removed from + its host window, regardless of whether it is still in an NSWindow. Our documentation pretty + strongly implies that plugins and JavaScript will not work in a WebView that has no host window. This seems completely wrong to me. Regardless of how the documentation is written, plug-ins are supposed to work in WebViews even if we don't explicitly set a host window. The point of hostWindow is to allow a view to remain attached to a window when it's not in the window any more, but for simple WebView uses where there's no need to detach and reattach the view to a window, you wdon't need to use hostWindow at all. It was really added so we could support tabs. If we need to update the documentation, that's fine, but we should not change plug-ins and JavaScript to work only when a hostWindow is set.

Tim Omernick

Comment 9 2006-04-26 12:40:51 PDT

Created attachment 7985 [details] Patch to address Darin's comments I didn't realize that setting the host window was optional. I removed that change, and also switched to -makeObjectsPerformSelector:.

Geoffrey Garen

Comment 10 2006-04-26 13:03:40 PDT

Comment on attachment 7985 [details] Patch to address Darin's comments r=me

Tim Omernick

Comment 11 2006-04-26 13:15:20 PDT

Fix landed to TOT WebKit, revision 14075.

Note You need to log in before you can comment on or make changes to this bug.