Summary: | Web Inspector: annotate ProfilerAgent. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Ilya Tikhonovsky <loislo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Ilya Tikhonovsky
2012-05-04 09:00:17 PDT
Created attachment 140249 [details]
Patch
Comment on attachment 140249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140249&action=review > Source/WebCore/inspector/front-end/ProfilesPanel.js:367 > + this._profilesIdMap[this._makeKey('' + profile.uid, typeId)] = profile; You should probably fix the _makeKey() signature instead? > Source/WebCore/inspector/front-end/ProfilesPanel.js:547 > + var profile = this._profilesIdMap[this._makeKey('' + uid, WebInspector.HeapSnapshotProfileType.TypeId)]; Ditto > Source/WebCore/inspector/front-end/ProfilesPanel.js:558 > + var profile = this._profilesIdMap[this._makeKey('' + uid, WebInspector.HeapSnapshotProfileType.TypeId)]; Ditto Created attachment 140255 [details]
Patch
Created attachment 140257 [details]
Patch
Committed r116210: <http://trac.webkit.org/changeset/116210> |