Bug 85630

Summary: Web Inspector: annotate ProfilerAgent.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch pfeldman: review+

Description Ilya Tikhonovsky 2012-05-04 09:00:17 PDT
%subj%
Comment 1 Ilya Tikhonovsky 2012-05-04 09:20:23 PDT
Created attachment 140249 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2012-05-04 09:26:50 PDT
Comment on attachment 140249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140249&action=review

> Source/WebCore/inspector/front-end/ProfilesPanel.js:367
> +        this._profilesIdMap[this._makeKey('' + profile.uid, typeId)] = profile;

You should probably fix the _makeKey() signature instead?

> Source/WebCore/inspector/front-end/ProfilesPanel.js:547
> +        var profile = this._profilesIdMap[this._makeKey('' + uid, WebInspector.HeapSnapshotProfileType.TypeId)];

Ditto

> Source/WebCore/inspector/front-end/ProfilesPanel.js:558
> +        var profile = this._profilesIdMap[this._makeKey('' + uid, WebInspector.HeapSnapshotProfileType.TypeId)];

Ditto
Comment 3 Ilya Tikhonovsky 2012-05-04 09:35:17 PDT
Created attachment 140255 [details]
Patch
Comment 4 Ilya Tikhonovsky 2012-05-04 09:46:31 PDT
Created attachment 140257 [details]
Patch
Comment 5 Ilya Tikhonovsky 2012-05-04 23:51:53 PDT
Committed r116210: <http://trac.webkit.org/changeset/116210>