Summary: | [Qt] REGRESSION: 7 tests started to fail with newer Qt5 | ||
---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED INVALID | ||
Severity: | Critical | CC: | hausmann, menard, ossy |
Priority: | P1 | Keywords: | Qt, QtTriaged |
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | |||
Bug Blocks: | 79666, 79668 |
Description
Csaba Osztrogonác
2012-05-04 08:40:16 PDT
I skipped them - http://trac.webkit.org/changeset/116106 Please unskip with the proper fix. It isn't Qt5-WK2 specific, but Qt5 specific. Skiplist will be fixed. Skiplist fix landed in http://trac.webkit.org/changeset/116108 Tracked in Qt by : https://codereview.qt-project.org/#change,25778 (In reply to comment #4) > Tracked in Qt by : > > https://codereview.qt-project.org/#change,25778 Landed in Qt master. All these tests should be unskipped when we update to newer Qt. (In reply to comment #5) > (In reply to comment #4) > > Tracked in Qt by : > > > > https://codereview.qt-project.org/#change,25778 > > Landed in Qt master. All these tests should be unskipped when we update to newer Qt. It fixed only these tests: fast/encoding/char-decoding.html fast/loader/data-url-encoding-html.html fast/loader/data-url-encoding-svg.html But the following tests still fail: fast/encoding/percent-escaping.html http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode.html http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair.html http/tests/security/xssAuditor/script-tag-with-16bit-unicode2.html http/tests/security/xssAuditor/script-tag-with-16bit-unicode5.html http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding.html (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Tracked in Qt by : > > > > > > https://codereview.qt-project.org/#change,25778 > > > > Landed in Qt master. All these tests should be unskipped when we update to newer Qt. > > It fixed only these tests: > fast/encoding/char-decoding.html > fast/loader/data-url-encoding-html.html > fast/loader/data-url-encoding-svg.html > > But the following tests still fail: > fast/encoding/percent-escaping.html > http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode.html > http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair.html > http/tests/security/xssAuditor/script-tag-with-16bit-unicode2.html > http/tests/security/xssAuditor/script-tag-with-16bit-unicode5.html > http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html > http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding.html darktears@DarthVader:~/dev/troll/webkit$ WEBKITOUTPUTDIR=/home/darktears/dev/troll/webkit2-trunk run-webkit-tests --qt -2 --release --iterations 100 LayoutTests/http/tests/security/xssAuditor Running new-run-webkit-tests with one child process. For more parallelism, run new-run-webkit-tests directly. All 16200 tests ran as expected. WEBKITOUTPUTDIR=/home/darktears/dev/troll/webkit2-trunk run-webkit-tests --qt 388.65s user 74.10s system 97% cpu 7:55.44 total darktears@DarthVader:~/dev/troll/webkit$ WEBKITOUTPUTDIR=/home/darktears/dev/troll/webkit2-trunk run-webkit-tests --qt --release --iterations 100 LayoutTests/http/tests/security/xssAuditor Running new-run-webkit-tests with one child process. For more parallelism, run new-run-webkit-tests directly. TAll 16200 tests ran as expected. WEBKITOUTPUTDIR=/home/darktears/dev/troll/webkit2-trunk run-webkit-tests --qt 136.87s user 10.16s system 36% cpu 6:37.74 total (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (In reply to comment #4) > > > > Tracked in Qt by : > > > > > > > > https://codereview.qt-project.org/#change,25778 > > > > > > Landed in Qt master. All these tests should be unskipped when we update to newer Qt. > > > > It fixed only these tests: > > fast/encoding/char-decoding.html > > fast/loader/data-url-encoding-html.html > > fast/loader/data-url-encoding-svg.html > > > > But the following tests still fail: > > fast/encoding/percent-escaping.html > > http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode.html > > http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair.html > > http/tests/security/xssAuditor/script-tag-with-16bit-unicode2.html > > http/tests/security/xssAuditor/script-tag-with-16bit-unicode5.html > > http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html > > http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding.html > > darktears@DarthVader:~/dev/troll/webkit$ WEBKITOUTPUTDIR=/home/darktears/dev/troll/webkit2-trunk run-webkit-tests --qt -2 --release --iterations 100 LayoutTests/http/tests/security/xssAuditor > Running new-run-webkit-tests with one child process. > For more parallelism, run new-run-webkit-tests directly. > All 16200 tests ran as expected. > > WEBKITOUTPUTDIR=/home/darktears/dev/troll/webkit2-trunk run-webkit-tests --qt 388.65s user 74.10s system 97% cpu 7:55.44 total > darktears@DarthVader:~/dev/troll/webkit$ WEBKITOUTPUTDIR=/home/darktears/dev/troll/webkit2-trunk run-webkit-tests --qt --release --iterations 100 LayoutTests/http/tests/security/xssAuditor > Running new-run-webkit-tests with one child process. > For more parallelism, run new-run-webkit-tests directly. > TAll 16200 tests ran as expected. > > WEBKITOUTPUTDIR=/home/darktears/dev/troll/webkit2-trunk run-webkit-tests --qt 136.87s user 10.16s system 36% cpu 6:37.74 total fast/encoding/percent-escaping.html is also passing I still get failing tests on Ubuntu 11.10 and on Debian Squeeze ... ( I bet you tried them on your Arch or on Mac. :) ) The bug is still valid now. 3 tests pass now: - fast/encoding/char-decoding.html - fast/loader/data-url-encoding-html.html - fast/loader/data-url-encoding-svg.html but the remaining 7 tests still fail with the same diff adding 79668, because one test fails with timeout, not a simple fail: --- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/fast/encoding/percent-escaping-expected.txt +++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/fast/encoding/percent-escaping-actual.txt @@ -1,3 +1,2 @@ -Test for bug 6452 - KURL::appendEscapingBadChars() should never escape percent characters. +FAIL: Timed out waiting for notifyDone to be called -SUCCESS I unskipped the 3 passing test - r135385. |