Summary: | [BlackBerry] Enable credential persistance and auto fill | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Dong <jonathan.dong.webkit> | ||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | charles.wei, leo.yang, mstaikos, rakuco, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jonathan Dong
2012-05-03 19:54:46 PDT
Created attachment 140153 [details]
Patch
Comment on attachment 140153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140153&action=review Looks good, wondering about the minor fix line? > Source/WebKit/blackberry/ChangeLog:10 > + This is a minor fix by the way. I dont get this line? Better clear it up before landing. Comment on attachment 140153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140153&action=review >> Source/WebKit/blackberry/ChangeLog:10 >> + This is a minor fix by the way. > > I dont get this line? Better clear it up before landing. Thanks Rob, calling setAutofilled() on the input element will get it painted with yellow background which can notify user this input is auto filled by browser. I forget to add this in the former patches. will explain this in changelog with my next patch. Created attachment 140225 [details]
Patch
Comment on attachment 140225 [details]
Patch
Looks good, I hope Leo, Charles or Mary can help with landing.
hi Rob, do you know what's wrong with it? Charles has helped on cq+ this patch in the early morning this Saturday, but it hasn't get landed yet until now, and there's no status update. Do I need to re-submit it? and we are not able to see the build status here in china, :( Hi Jonathan, (In reply to comment #6) > hi Rob, do you know what's wrong with it? Charles has helped on cq+ this patch in the early morning this Saturday, but it hasn't get landed yet until now, and there's no status update. Do I need to re-submit it? > > and we are not able to see the build status here in china, :( Maybe the queue is stuck, I'll keep an eye on it. Comment on attachment 140225 [details] Patch Clearing flags on attachment: 140225 Committed r116241: <http://trac.webkit.org/changeset/116241> All reviewed patches have been landed. Closing bug. |