Bug 85567

Summary:

Add PNG image pngsuite test

Product:

WebKit

Reporter:

noel gordon <noel.gordon>

Component:

Tools / Tests

Assignee:

noel gordon <noel.gordon>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

caseq, eric, hyatt, pkasting, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch merge to tip	none

noel gordon

Reported 2012-05-03 18:30:44 PDT

Add PNG image pngsuite from http://www.schaik.com/pngsuite

Attachments
Patch (584.64 KB, patch) 2012-05-03 18:49 PDT, noel gordon	no flags	Details Formatted Diff Diff
Patch merge to tip (584.59 KB, patch) 2012-05-03 23:40 PDT, noel gordon	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

noel gordon

Comment 1 2012-05-03 18:49:02 PDT

Created attachment 140144 [details] Patch

Eric Seidel (no email)

Comment 2 2012-05-03 22:51:58 PDT

Comment on attachment 140144 [details] Patch Fantastic!

WebKit Review Bot

Comment 3 2012-05-03 22:58:20 PDT

Comment on attachment 140144 [details] Patch Rejecting attachment 140144 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /platform/efl/test_expectations.txt.rej patching file LayoutTests/platform/gtk/test_expectations.txt patching file LayoutTests/platform/qt/test_expectations.txt Hunk #1 FAILED at 64. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/test_expectations.txt.rej patching file LayoutTests/platform/wincairo/Skipped Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12633054

noel gordon

Comment 4 2012-05-03 23:40:49 PDT

Created attachment 140167 [details] Patch merge to tip

WebKit Review Bot

Comment 5 2012-05-04 00:24:43 PDT

Comment on attachment 140167 [details] Patch merge to tip Clearing flags on attachment: 140167 Committed r116074: <http://trac.webkit.org/changeset/116074>

WebKit Review Bot

Comment 6 2012-05-04 00:24:49 PDT

All reviewed patches have been landed. Closing bug.

Andrey Kosyakov

Comment 7 2012-05-04 03:21:51 PDT

FWIW, the chromium tests fail with missing result -- so I changed the expectations from IMAGE to MISSING.

noel gordon

Comment 8 2012-05-04 03:33:15 PDT

Thanks, had the expectation as = IMAGE MISSING and the linux EWS complained about that :(

noel gordon

Comment 9 2012-05-04 03:37:29 PDT

Landed chromium rebaselines n http://trac.webkit.org/changeset/116081

Note You need to log in before you can comment on or make changes to this bug.