Bug 85504

Summary: webkitpy: Style checker broken when committing a PNG
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: Tools / TestsAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, levin, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
dpranke: review-, dpranke: commit-queue-
patch none

Thiago Marcos P. Santos
Reported 2012-05-03 08:52:47 PDT
$ ./Tools/Scripts/check-webkit-style -g HEAD Traceback (most recent call last): File "./Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check self._text_file_reader.process_file(file_path=path, line_numbers=None) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file self._processor.process(lines, file_path, **kwargs) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/checker.py", line 844, in process min_confidence) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/checker.py", line 619, in dispatch min_confidence) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/checker.py", line 593, in _create_checker checker = PNGChecker(file_path, handle_style_error) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/checkers/png.py", line 43, in __init__ self._fs = host.filesystem AttributeError: 'NoneType' object has no attribute 'filesystem'
Attachments
Patch (1.34 KB, text/plain)
2012-05-03 08:57 PDT, Thiago Marcos P. Santos 		dpranke: review-
dpranke: commit-queue-
Details
patch (1.18 KB, patch)
2012-05-03 09:15 PDT, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2012-05-03 08:57:03 PDT
Created attachment 140026 [details] Patch
Dirk Pranke
Comment 2 2012-05-03 09:01:59 PDT
Comment on attachment 140026 [details] Patch thanks for looking at this, but I'm pretty sure that would assign self._fs to host if host is non-null. Just change host to self._host on line 43.
Thiago Marcos P. Santos
Comment 3 2012-05-03 09:03:17 PDT
(In reply to comment #2) > (From update of attachment 140026 [details]) > thanks for looking at this, but I'm pretty sure that would assign self._fs to host if host is non-null. Just change host to self._host on line 43. Yeah, I noticed that when running the utests here.
Thiago Marcos P. Santos
Comment 4 2012-05-03 09:15:16 PDT
Created attachment 140032 [details] patch Fixes previous patch
Dirk Pranke
Comment 5 2012-05-03 09:16:03 PDT
Comment on attachment 140032 [details] patch thanks!
WebKit Review Bot
Comment 6 2012-05-03 10:06:34 PDT
Comment on attachment 140032 [details] patch Clearing flags on attachment: 140032 Committed r115986: <http://trac.webkit.org/changeset/115986>
WebKit Review Bot
Comment 7 2012-05-03 10:06:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.