Bug 85475

Summary:

run-qtwebkit-tests hangs with -j1

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Major

CC:

galpeter, jbadics, jesus, kadam, ossy, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	none
proposed patch	none

Csaba Osztrogonác

Reported 2012-05-03 04:31:44 PDT

Tool/Scripts/run-qtwebkit-tests hangs after it ran all Qt API tests with -j1 (run only one job) It should be fixed.

Attachments
Proposed patch (1.20 KB, patch) 2012-06-05 01:48 PDT, János Badics	no flags	Details Formatted Diff Diff
proposed patch (1.22 KB, patch) 2012-06-05 02:44 PDT, János Badics	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ádám Kallai

Comment 1 2012-05-08 01:46:36 PDT

I'm going to check what causes this problem.

János Badics

Comment 2 2012-06-05 01:48:55 PDT

Created attachment 145726 [details] Proposed patch It's likely that this could be solved by canceling the timer of process_killer when results of tests are returned.

Peter Gal

Comment 3 2012-06-05 02:07:36 PDT

View in context: https://bugs.webkit.org/attachment.cgi?id=145726&action=review > Tools/Scripts/run-qtwebkit-tests:158 > log.info("Finished %s", test_suite.test_file_name()) > + timer.cancel() > return test_suite This is not in the correct place. If timeout is not set the 'timer' will be a "None" value, calling cancel() on that will result an AttributeError. You should check if the timer is set to a valid object. So I would give an r- for now (sadly I can't set that flag).

János Badics

Comment 4 2012-06-05 02:44:52 PDT

Created attachment 145738 [details] proposed patch

Peter Gal

Comment 5 2012-06-05 02:50:02 PDT

View in context: https://bugs.webkit.org/attachment.cgi?id=145738&action=review > Tools/Scripts/run-qtwebkit-tests:158 > + if timeout: > + timer.cancel() Now it looks a lot better. I'll give it a non-reviewer r+ :)

János Badics

Comment 6 2012-06-05 03:46:41 PDT

(In reply to comment #5) > View in context: https://bugs.webkit.org/attachment.cgi?id=145738&action=review > Now it looks a lot better. I'll give it a non-reviewer r+ :) Thank you. : )

Csaba Osztrogonác

Comment 7 2012-06-06 05:48:16 PDT

Comment on attachment 145738 [details] proposed patch r=me. Thanks for the fix.

WebKit Review Bot

Comment 8 2012-06-06 06:09:22 PDT

Comment on attachment 145738 [details] proposed patch Clearing flags on attachment: 145738 Committed r119588: <http://trac.webkit.org/changeset/119588>

WebKit Review Bot

Comment 9 2012-06-06 06:09:27 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.