Bug 85445

Summary: Fix tabs vs. space formating in FeatureDefines.vsprops and fix alphabetical sorting
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jberlin, lforschler, sfalken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85456    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2012-05-02 18:32:05 PDT
Fix tabs vs. space formating in FeatureDefines.vsprops and fix alphabetical sorting
Attachments
Patch (6.40 KB, patch)
2012-05-02 18:32 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-05-02 18:32:55 PDT
Created attachment 139934 [details] Patch
Eric Seidel (no email)
Comment 2 2012-05-02 18:34:13 PDT
I very intentionally did not change any functionality here. I did not add or remove any ENABLE macros, just sorting. I'll come back and sort the PreprocessorDefinitions="...." line at a later time (it's also only mostly alphabetical), since it's very long and hard to see in the diff.
Eric Seidel (no email)
Comment 3 2012-05-02 18:35:12 PDT
I noticed that this file is set to eol=native. I spoke with Lucas over IRC, and was told that should be correct. With luck this diff will apply, land and be checked-out with the proper line endings. :)
Eric Seidel (no email)
Comment 4 2012-05-02 18:35:28 PDT
Note to reviewers: the win-ews should turn green before this lands.
Eric Seidel (no email)
Comment 5 2012-05-02 18:40:44 PDT
bug 85433 is the equivalent re-sort for the Mac/IOS port.
WebKit Review Bot
Comment 6 2012-05-02 20:32:56 PDT
Comment on attachment 139934 [details] Patch Clearing flags on attachment: 139934 Committed r115934: <http://trac.webkit.org/changeset/115934>
WebKit Review Bot
Comment 7 2012-05-02 20:33:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.