|Summary:||Fix tabs vs. space formating in FeatureDefines.vsprops and fix alphabetical sorting|
|Product:||WebKit||Reporter:||Eric Seidel (no email) <eric>|
|Component:||New Bugs||Assignee:||Eric Seidel (no email) <eric>|
|Severity:||Normal||CC:||abarth, jberlin, lforschler, sfalken, webkit.review.bot|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Eric Seidel (no email) 2012-05-02 18:32:05 PDT
Fix tabs vs. space formating in FeatureDefines.vsprops and fix alphabetical sorting
Comment 2 Eric Seidel (no email) 2012-05-02 18:34:13 PDT
I very intentionally did not change any functionality here. I did not add or remove any ENABLE macros, just sorting. I'll come back and sort the PreprocessorDefinitions="...." line at a later time (it's also only mostly alphabetical), since it's very long and hard to see in the diff.
Comment 3 Eric Seidel (no email) 2012-05-02 18:35:12 PDT
I noticed that this file is set to eol=native. I spoke with Lucas over IRC, and was told that should be correct. With luck this diff will apply, land and be checked-out with the proper line endings. :)
Comment 4 Eric Seidel (no email) 2012-05-02 18:35:28 PDT
Note to reviewers: the win-ews should turn green before this lands.
Comment 5 Eric Seidel (no email) 2012-05-02 18:40:44 PDT
bug 85433 is the equivalent re-sort for the Mac/IOS port.
Comment 6 WebKit Review Bot 2012-05-02 20:32:56 PDT
Comment on attachment 139934 [details] Patch Clearing flags on attachment: 139934 Committed r115934: <http://trac.webkit.org/changeset/115934>
Comment 7 WebKit Review Bot 2012-05-02 20:33:01 PDT
All reviewed patches have been landed. Closing bug.