| Summary: | Fix tabs vs. space formating in FeatureDefines.vsprops and fix alphabetical sorting | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
| Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, jberlin, lforschler, sfalken, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 85456 | ||||||
| Attachments: |
|
||||||
|
Description
Eric Seidel (no email)
2012-05-02 18:32:05 PDT
Created attachment 139934 [details]
Patch
I very intentionally did not change any functionality here. I did not add or remove any ENABLE macros, just sorting. I'll come back and sort the PreprocessorDefinitions="...." line at a later time (it's also only mostly alphabetical), since it's very long and hard to see in the diff. I noticed that this file is set to eol=native. I spoke with Lucas over IRC, and was told that should be correct. With luck this diff will apply, land and be checked-out with the proper line endings. :) Note to reviewers: the win-ews should turn green before this lands. bug 85433 is the equivalent re-sort for the Mac/IOS port. Comment on attachment 139934 [details] Patch Clearing flags on attachment: 139934 Committed r115934: <http://trac.webkit.org/changeset/115934> All reviewed patches have been landed. Closing bug. |