Bug 85436

Summary: webkitpy: Remove sys.platform accesses in CrashLogs.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: Tools / TestsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aestes, dpranke, eric, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 85452    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Same patch with the missing import statement dpranke: review+

Raphael Kubo da Costa (:rakuco)
Reported 2012-05-02 17:11:27 PDT
webkitpy: Remove sys.platform accesses in CrashLogs.
Attachments
Patch (8.11 KB, patch)
2012-05-02 17:12 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Same patch with the missing import statement (8.10 KB, patch)
2012-05-03 08:06 PDT, Raphael Kubo da Costa (:rakuco) 		dpranke: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-05-02 17:12:26 PDT
Created attachment 139920 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-05-02 17:30:29 PDT
Committed r115918: <http://trac.webkit.org/changeset/115918>
Andy Estes
Comment 3 2012-05-02 20:09:29 PDT
This is causing test-webkitpy to fail on Apple's Lion bot. See <http://build.webkit.org/builders/Lion%20Debug%20%28Tests%29/builds/6134/steps/webkitpy-test/logs/stdio>
Andy Estes
Comment 4 2012-05-02 21:08:52 PDT
Rolled out in <http://trac.webkit.org/changeset/115935>.
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-05-03 08:06:39 PDT
Created attachment 140017 [details] Same patch with the missing import statement
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-05-03 09:22:43 PDT
Committed r115977: <http://trac.webkit.org/changeset/115977>
Note You need to log in before you can comment on or make changes to this bug.