Bug 85433

Summary: Sort ENABLE_ defines in FeatureDefines.xcconfig files to make them easier to compare with one another (and easier to autogenerate)
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, mrowe, rniwa, timothy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85456    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2012-05-02 16:38:55 PDT
Sort ENABLE_ defines in FeatureDefines.xcconfig files to make them easier to compare with one another (and easier to autogenerate)
Attachments
Patch (23.31 KB, patch)
2012-05-02 16:44 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-05-02 16:44:01 PDT
Created attachment 139915 [details] Patch
Eric Seidel (no email)
Comment 2 2012-05-02 16:46:05 PDT
I sorted each file by itself, so as to be sure not to change their contents at all. This patch very-intentionally should have no functional change. I also removed the arbitrary spacing between various defines, as now that they have a well defined ordering, there isn't a lot of point. Once I post my auto-gen script, it will be very easy to make these files look however we like, and change it as many times as we like, w/o worrying about whether they are kept perfectly in sync with one another.
Eric Seidel (no email)
Comment 3 2012-05-02 18:40:58 PDT
bug 85435 is the equivalent re-sort for the Win port.
Eric Seidel (no email)
Comment 4 2012-05-02 18:41:15 PDT
I meant bug 85445 of course. :)
WebKit Review Bot
Comment 5 2012-05-02 19:51:32 PDT
Comment on attachment 139915 [details] Patch Clearing flags on attachment: 139915 Committed r115931: <http://trac.webkit.org/changeset/115931>
WebKit Review Bot
Comment 6 2012-05-02 19:51:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.