Bug 85431

Summary:

webkitpy: Special-case win32 calls in file_lock and executive.

Product:

WebKit

Reporter:

Raphael Kubo da Costa (:rakuco) <rakuco>

Component:

Tools / Tests

Assignee:

Raphael Kubo da Costa (:rakuco) <rakuco>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, eric, ojan, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dpranke: review+

Raphael Kubo da Costa (:rakuco)

Reported 2012-05-02 16:37:01 PDT

webkitpy: Special-case win32 calls in file_lock and executive.

Attachments
Patch (3.58 KB, patch) 2012-05-02 16:38 PDT, Raphael Kubo da Costa (:rakuco)	dpranke: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Raphael Kubo da Costa (:rakuco)

Comment 1 2012-05-02 16:38:09 PDT

Created attachment 139910 [details] Patch

Dirk Pranke

Comment 2 2012-05-02 16:42:51 PDT

Comment on attachment 139910 [details] Patch have you added a platforminfo.is_win32() yet?

Raphael Kubo da Costa (:rakuco)

Comment 3 2012-05-02 16:44:28 PDT

(In reply to comment #2) > (From update of attachment 139910 [details]) > have you added a platforminfo.is_win32() yet? Nope, I'm sort of normalizing accesses to sys.platform first.

Raphael Kubo da Costa (:rakuco)

Comment 4 2012-05-02 16:47:39 PDT

Committed r115912: <http://trac.webkit.org/changeset/115912>

Note You need to log in before you can comment on or make changes to this bug.