Bug 85431

Summary:

webkitpy: Special-case win32 calls in file_lock and executive.

Product:

WebKit

Reporter:

Raphael Kubo da Costa (:rakuco) <rakuco>

Component:

Tools / Tests

Assignee:

Raphael Kubo da Costa (:rakuco) <rakuco>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, eric, ojan, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dpranke: review+

Description Raphael Kubo da Costa (:rakuco) 2012-05-02 16:37:01 PDT

webkitpy: Special-case win32 calls in file_lock and executive.

Comment 1 Raphael Kubo da Costa (:rakuco) 2012-05-02 16:38:09 PDT

Created attachment 139910 [details]
Patch

Comment 2 Dirk Pranke 2012-05-02 16:42:51 PDT

Comment on attachment 139910 [details]
Patch

have you added a platforminfo.is_win32() yet?

Comment 3 Raphael Kubo da Costa (:rakuco) 2012-05-02 16:44:28 PDT

(In reply to comment #2)
> (From update of attachment 139910 [details])
> have you added a platforminfo.is_win32() yet?

Nope, I'm sort of normalizing accesses to sys.platform first.

Comment 4 Raphael Kubo da Costa (:rakuco) 2012-05-02 16:47:39 PDT

Committed r115912: <http://trac.webkit.org/changeset/115912>