Bug 85431 - webkitpy: Special-case win32 calls in file_lock and executive.
Summary: webkitpy: Special-case win32 calls in file_lock and executive.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-02 16:37 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-05-02 16:47 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.58 KB, patch)
2012-05-02 16:38 PDT, Raphael Kubo da Costa (:rakuco) 		dpranke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-05-02 16:37:01 PDT 
webkitpy: Special-case win32 calls in file_lock and executive.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-05-02 16:38:09 PDT 
Created attachment 139910 [details]
Patch
Comment 2 Dirk Pranke 2012-05-02 16:42:51 PDT 
Comment on attachment 139910 [details]
Patch

have you added a platforminfo.is_win32() yet?
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-05-02 16:44:28 PDT 
(In reply to comment #2)
> (From update of attachment 139910 [details])
> have you added a platforminfo.is_win32() yet?

Nope, I'm sort of normalizing accesses to sys.platform first.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-05-02 16:47:39 PDT 
Committed r115912: <http://trac.webkit.org/changeset/115912>