Bug 85426

Summary: webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: Tools / TestsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, levin, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dpranke: review+

Raphael Kubo da Costa (:rakuco)
Reported 2012-05-02 15:46:04 PDT
webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
Attachments
Patch (8.25 KB, patch)
2012-05-02 15:48 PDT, Raphael Kubo da Costa (:rakuco) 		dpranke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-05-02 15:48:51 PDT
Created attachment 139896 [details] Patch
Dirk Pranke
Comment 2 2012-05-02 15:51:21 PDT
Comment on attachment 139896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139896&action=review > Tools/Scripts/webkitpy/common/system/systemhost_mock.py:40 > + self.filesystem = filesystem or MockFileSystem() Since things like executive, filesystem are public properties, I sometimes will construct the object with the default values and then set the property, rather than passing it in (which is why filesystem wasn't previously a parameter). I don't know that my approach was better or worse than this, though.
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-05-02 15:54:57 PDT
Committed r115900: <http://trac.webkit.org/changeset/115900>
Note You need to log in before you can comment on or make changes to this bug.