| Summary: | [chromium] Ensure synchronization in threaded unit tests by checking the sourceFrameNumber() to count commits | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dana Jansens <danakj> | ||||||||
| Component: | New Bugs | Assignee: | Dana Jansens <danakj> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | backer, enne, jamesr, piman, reveman, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dana Jansens
2012-05-02 10:54:43 PDT
Created attachment 139844 [details]
Patch
Created attachment 139852 [details]
Patch
Use sourceFrameNumber everywhere in the atomic commit tests, and put back removed resetUsedTextures() calls
Comment on attachment 139852 [details]
Patch
Ack, yes. R=me.
Comment on attachment 139852 [details] Patch Rejecting attachment 139852 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 748 (offset -2 lines). Hunk #5 succeeded at 1815 (offset -2 lines). Hunk #6 succeeded at 1830 (offset -2 lines). Hunk #7 succeeded at 1846 (offset -2 lines). Hunk #8 succeeded at 1886 (offset -2 lines). Hunk #9 FAILED at 2482. 1 out of 9 hunks FAILED -- saving rejects to file Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adrienne W..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12649175 Created attachment 140604 [details]
Patch for landing
Comment on attachment 140604 [details] Patch for landing Clearing flags on attachment: 140604 Committed r116362: <http://trac.webkit.org/changeset/116362> All reviewed patches have been landed. Closing bug. |