Bug 85390

Summary: [chromium] Ensure synchronization in threaded unit tests by checking the sourceFrameNumber() to count commits
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: backer, enne, jamesr, piman, reveman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Dana Jansens
Reported 2012-05-02 10:54:43 PDT
[chromium] Ensure synchronization in threaded unit tests by checking the sourceFrameNumber() to count commits
Attachments
Patch (6.98 KB, patch)
2012-05-02 11:26 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (6.19 KB, patch)
2012-05-02 12:03 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.82 KB, patch)
2012-05-07 15:24 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-05-02 11:26:37 PDT
Created attachment 139844 [details] Patch
Dana Jansens
Comment 2 2012-05-02 12:03:34 PDT
Created attachment 139852 [details] Patch Use sourceFrameNumber everywhere in the atomic commit tests, and put back removed resetUsedTextures() calls
Adrienne Walker
Comment 3 2012-05-07 14:37:20 PDT
Comment on attachment 139852 [details] Patch Ack, yes. R=me.
WebKit Review Bot
Comment 4 2012-05-07 14:42:31 PDT
Comment on attachment 139852 [details] Patch Rejecting attachment 139852 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 748 (offset -2 lines). Hunk #5 succeeded at 1815 (offset -2 lines). Hunk #6 succeeded at 1830 (offset -2 lines). Hunk #7 succeeded at 1846 (offset -2 lines). Hunk #8 succeeded at 1886 (offset -2 lines). Hunk #9 FAILED at 2482. 1 out of 9 hunks FAILED -- saving rejects to file Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adrienne W..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12649175
Dana Jansens
Comment 5 2012-05-07 15:24:48 PDT
Created attachment 140604 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-05-07 15:59:32 PDT
Comment on attachment 140604 [details] Patch for landing Clearing flags on attachment: 140604 Committed r116362: <http://trac.webkit.org/changeset/116362>
WebKit Review Bot
Comment 7 2012-05-07 15:59:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.