| Summary: | [jhbuild] [EFL] Bump EFL and libffi dependencies. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||||||||||
| Component: | Tools / Tests | Assignee: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | d-r, gustavo, gyuyoung.kim, mrobinson, pnormand, webkit.review.bot | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Bug Depends on: | 85790 | ||||||||||||||||
| Bug Blocks: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Raphael Kubo da Costa (:rakuco)
2012-05-02 07:17:51 PDT
Created attachment 139809 [details]
Patch
Created attachment 139811 [details]
Fix the libffi version in the ChangeLog
Created attachment 139813 [details]
Update fonts as well after talking to Dominik
Generally looks okay to me - let me check this patch on a DRT run locally before landing. Missing change for updated fonts as in http://pastebin.com/avru408M Ran it locally, results are about the same as buildbot. Fine with me with that change and the caveat that the buildbots need a clean WebKitBuild/Dependencies folder, otherwise jhbuild update does not cleanly complete. Created attachment 140230 [details]
Update -DDOWNLOADED_FONTS_DIR
CC'ing a few jhbuild-related people for an r+ (In reply to comment #5) > Ran it locally, results are about the same as buildbot. Fine with me with that change and the caveat that the buildbots need a clean WebKitBuild/Dependencies folder, otherwise jhbuild update does not cleanly complete. We fixed that by keeping an md5sum of the jhbuild configuration files and wiping the directories when they change (in webkitdirs.pm), you may want to do the same! Comment on attachment 140230 [details]
Update -DDOWNLOADED_FONTS_DIR
As discussed on IRC, would be good to have the reasons for the bumping in the ChangeLog.
Created attachment 140239 [details]
Patch for landing with a better ChangeLog
(In reply to comment #8) > We fixed that by keeping an md5sum of the jhbuild configuration files and wiping the directories when they change (in webkitdirs.pm), you may want to do the same! True, filed as bug 85790. Marking this one as depending on bug 85790, as I feel more confident landing this one after that. Hello Kubo, In Bug 90333, I submit a patch to bump efl libraries. If Bug 90333 can support this patch as well, can you update this patch again ? If not so, please let me know. These days all the dependencies bumped in this patch have already been updated, except for libffi. I'll work on that soon. Created attachment 150529 [details]
Patch
Comment on attachment 150529 [details]
Patch
Looks good to me.
Comment on attachment 150529 [details] Patch Clearing flags on attachment: 150529 Committed r121782: <http://trac.webkit.org/changeset/121782> All reviewed patches have been landed. Closing bug. |