Bug 85309

Summary: supportsExpandedScrollbars() should check for the method we actually call rather than a related method
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, darin
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Beth Dakin
Reported 2012-05-01 14:15:43 PDT
In ScrollbarThemeMac, supportsExpandedScrollbars() checked if NSScrollerImp responds to isExpanded. The result of this function is used to determine whether or not is it safe to call setExpanded. We should just check for setExpanded instead. <rdar://problem/11065691>
Attachments
Patch (1.55 KB, patch)
2012-05-01 14:18 PDT, Beth Dakin 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2012-05-01 14:18:11 PDT
Created attachment 139678 [details] Patch
Beth Dakin
Comment 2 2012-05-02 06:42:32 PDT
Thanks Anders! http://trac.webkit.org/changeset/115823
Darin Adler
Comment 3 2012-05-02 11:19:58 PDT
This patch was wrong! The selector is setExpanded: with the colon, not setExpanded without a colon!
Anders Carlsson
Comment 4 2012-05-02 11:35:53 PDT
Oops!
Beth Dakin
Comment 5 2012-05-02 12:46:52 PDT
(In reply to comment #3) > This patch was wrong! The selector is setExpanded: with the colon, not setExpanded without a colon! Thanks for noticing that! Added the colon here: http://trac.webkit.org/changeset/115868
Note You need to log in before you can comment on or make changes to this bug.