Bug 85284

Summary: [BlackBerry] Add special attribute for alternate selection touch handling.
Product: WebKit Reporter: Mike Fenton <mifenton>
Component: WebKit BlackBerryAssignee: Mike Fenton <mifenton>
Status: RESOLVED FIXED    
Severity: Normal CC: chutten, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Rename Attribute patch. none

Mike Fenton
Reported 2012-05-01 08:07:42 PDT
SSIA.
Attachments
Patch (7.23 KB, patch)
2012-05-01 08:10 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
Rename Attribute patch. (3.47 KB, patch)
2012-05-03 08:00 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Fenton
Comment 1 2012-05-01 08:10:43 PDT
Created attachment 139629 [details] Patch
Antonio Gomes
Comment 2 2012-05-01 08:15:33 PDT
Comment on attachment 139629 [details] Patch bools :(
WebKit Review Bot
Comment 3 2012-05-01 08:32:09 PDT
Comment on attachment 139629 [details] Patch Clearing flags on attachment: 139629 Committed r115728: <http://trac.webkit.org/changeset/115728>
WebKit Review Bot
Comment 4 2012-05-01 08:32:15 PDT
All reviewed patches have been landed. Closing bug.
Chris H-C
Comment 5 2012-05-01 12:38:07 PDT
A little late now, but aren't vendor prefixes for HTML attributes supposed to be <vendor_name>_<attribute_name>, and the attribute-name should be camel-case, not hyphenated? It looks like a CSS property, not an HTML attribute.
Antonio Gomes
Comment 6 2012-05-02 22:02:36 PDT
(In reply to comment #4) > All reviewed patches have been landed. Closing bug. Agreed. We are fixing it.
Mike Fenton
Comment 7 2012-05-03 08:00:12 PDT
Created attachment 140013 [details] Rename Attribute patch.
Rob Buis
Comment 8 2012-05-03 08:03:29 PDT
Comment on attachment 140013 [details] Rename Attribute patch. Looks good.
WebKit Review Bot
Comment 9 2012-05-03 08:39:52 PDT
Comment on attachment 140013 [details] Rename Attribute patch. Clearing flags on attachment: 140013 Committed r115974: <http://trac.webkit.org/changeset/115974>
WebKit Review Bot
Comment 10 2012-05-03 08:39:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.