Bug 85279

Summary: [GTK] Transparent Media controls timeline and panel
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Philippe Normand
Reported 2012-05-01 06:39:09 PDT
RenderThemeGtk::initMediaColors() sets m_panelColor, m_sliderColor and m_sliderColor to transparent black... I suspect this might be the effect of the recent update of gtk+ from 3.0 to 3.4 in our JHBuild moduleset.
Attachments
Patch (2.85 KB, patch)
2012-07-27 08:29 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2012-05-01 07:25:09 PDT
Yep, reverting r114297 fixes the issue here.
Philippe Normand
Comment 2 2012-05-01 09:30:46 PDT
Carlos would you mind having a look at this issue? It's quite annoying. If a WebKit patch is needed it should also be cherry-picked in the stable branch if possible because this visual regression is quite annoying.
Carlos Garcia Campos
Comment 3 2012-05-07 08:30:54 PDT
I can't reproduce it with gtk+ from current git master
Philippe Normand
Comment 4 2012-05-12 14:15:19 PDT
(In reply to comment #3) > I can't reproduce it with gtk+ from current git master So, what should we do then? Update our jhbuild's GTK+ version or find/backport the GTK+ commit that fixed the issue? I'm open to both options...
Gustavo Noronha (kov)
Comment 5 2012-05-15 12:02:31 PDT
I'm fine with upgrading gtk+ in our jhbuild, unless it'd make it impossible to build our jhbuild stuff in fairly recent distributions, which I doubt will be the case.
Martin Robinson
Comment 6 2012-05-15 12:04:32 PDT
(In reply to comment #5) > I'm fine with upgrading gtk+ in our jhbuild, unless it'd make it impossible to build our jhbuild stuff in fairly recent distributions, which I doubt will be the case. The fix for this issue should probably be in WebKit as we need to work properly with all GTK+ versions that we support during configuration.
Gustavo Noronha (kov)
Comment 7 2012-05-15 12:12:26 PDT
We haven't really tried supporting all buggy versions of GTK+ or whatever else, specially bugs that come and go in a 1 release? =)
Martin Robinson
Comment 8 2012-05-15 12:13:49 PDT
(In reply to comment #7) > We haven't really tried supporting all buggy versions of GTK+ or whatever else, specially bugs that come and go in a 1 release? =) Apologies! I misread this thread and understood falsely that the problem existed from 3.0 to 3.4.
Philippe Normand
Comment 9 2012-06-28 15:47:51 PDT
I locally tried updating up to gtk+ 3.5.6 and still not seeing my media controls panel and timeline bar. Carlos, are you sure this all works fine for you in gtk+ master?
Carlos Garcia Campos
Comment 10 2012-06-29 04:57:26 PDT
Yes, I can see the media controls with both MiniBrowser and GtkLauncher.
Philippe Normand
Comment 11 2012-06-29 07:38:57 PDT
(In reply to comment #10) > Yes, I can see the media controls with both MiniBrowser and GtkLauncher. Can you attach a screenshot please? Just to make sure we're on the same page.
Philippe Normand
Comment 12 2012-07-27 08:29:05 PDT
Created attachment 154957 [details] Patch
Philippe Normand
Comment 13 2012-07-28 06:09:22 PDT
Comment on attachment 154957 [details] Patch Clearing flags on attachment: 154957 Committed r123959: <http://trac.webkit.org/changeset/123959>
Philippe Normand
Comment 14 2012-07-28 06:09:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.