Bug 85249

Summary: Change RenderBoxModelObject::calculateBackgroundImageGeometry to use roundToInt
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch none

Description Emil A Eklund 2012-04-30 17:40:35 PDT 
In RenderBoxModelObject::calculateBackgroundImageGeometry we need to use a modulo operator to compute the phase for the repeating background image. As the position will be a FractionalLayoutUnit we need to round it.
Comment 1 Emil A Eklund 2012-04-30 18:06:26 PDT 
Created attachment 139558 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-04-30 18:16:19 PDT 
Comment on attachment 139558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139558&action=review

> Source/WebCore/ChangeLog:9
> +        Prepare RenderBoxModelObject for FractionalLayoutUnits by adding rounding
> +        logic to calculateBackgroundImageGeometry.

Why?  Why should it round?  (i'm not saying it shouldn't,it's jus tnot very well explained here. :)
Comment 3 Emil A Eklund 2012-04-30 18:21:47 PDT 
Created attachment 139563 [details]
Patch
Comment 4 Emil A Eklund 2012-04-30 18:22:22 PDT 
Expanded on why.
Comment 5 Eric Seidel (no email) 2012-04-30 18:26:58 PDT 
Comment on attachment 139563 [details]
Patch

OK.
Comment 6 Emil A Eklund 2012-04-30 18:27:29 PDT 
Thanks Eric!
Comment 7 WebKit Review Bot 2012-04-30 20:23:59 PDT 
Comment on attachment 139563 [details]
Patch

Clearing flags on attachment: 139563

Committed r115707: <http://trac.webkit.org/changeset/115707>
Comment 8 WebKit Review Bot 2012-04-30 20:24:03 PDT 
All reviewed patches have been landed.  Closing bug.