Bug 85246

Summary:

Bytecode dumps should contain data about the state of get_by_id caches

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	barraclough: review+, gustavo: commit-queue-
patch for landing	none

Filip Pizlo

Reported 2012-04-30 16:40:03 PDT

Currently bytecode dumping has some code to print the state of StructureStubInfo's, but that code has rotted, and is does not provide very many details - for example it will not tell you the offsets that we are using, and it will not tell you the full chains (for prototype accesses) or lists (for polymorphic accesses) being used. As well, the old dumping code prints structure stub information out-of-line, which makes it a bit harder to grok. The old code (which is rotten) should be axed, and replaced by something more informative. Finally, it should be possible for the DFG to dump bytecode during parsing, so that we can see exactly what the DFG sees when making its optimization decisions.

Attachments
the patch (47.32 KB, patch) 2012-04-30 16:47 PDT, Filip Pizlo	barraclough: review+ gustavo: commit-queue-	Details Formatted Diff Diff
patch for landing (47.43 KB, patch) 2012-05-21 15:14 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.