|Summary:||Update LayoutUnit usage in InlineFlowBox and RenderWidget|
|Product:||WebKit||Reporter:||Levi Weintraub <leviw>|
|Component:||Layout and Rendering||Assignee:||Levi Weintraub <leviw>|
|Severity:||Normal||CC:||eae, eric, webkit.review.bot|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Levi Weintraub 2012-04-30 15:25:19 PDT
See changelog for description and justification.
Comment 2 Eric Seidel (no email) 2012-04-30 15:54:18 PDT
Comment on attachment 139534 [details] Patch The widget stuff definitely makes sense. r=me to land that. The InlineFlowBox change feels like it could use a comment to explain why it's rounding. Are lines always pixel-aligned?
Comment 3 Levi Weintraub 2012-04-30 15:57:08 PDT
(In reply to comment #2) > (From update of attachment 139534 [details]) > The widget stuff definitely makes sense. r=me to land that. The InlineFlowBox change feels like it could use a comment to explain why it's rounding. Are lines always pixel-aligned? Root boxes are. You'll notice that top, maxAscent, and FontMetrics::ascent are all integers. I was surprised to discover this as well. I'll add a comment.
Comment 4 Levi Weintraub 2012-04-30 16:07:31 PDT
Created attachment 139540 [details] Patch for landing
Comment 5 WebKit Review Bot 2012-04-30 16:41:21 PDT
Comment on attachment 139540 [details] Patch for landing Clearing flags on attachment: 139540 Committed r115689: <http://trac.webkit.org/changeset/115689>
Comment 6 WebKit Review Bot 2012-04-30 16:41:30 PDT
All reviewed patches have been landed. Closing bug.