Bug 85236

Summary: Oscillator must implement noteOn() and noteOff()
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, jer.noble, kbr, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kbr: review+

Chris Rogers
Reported 2012-04-30 14:47:19 PDT
Oscillator must implement noteOn() and noteOff()
Attachments
Patch (772.79 KB, patch)
2012-04-30 15:06 PDT, Chris Rogers 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2012-04-30 15:06:30 PDT
Created attachment 139527 [details] Patch
Kenneth Russell
Comment 2 2012-05-04 17:05:11 PDT
Comment on attachment 139527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139527&action=review Looks good to me per your offline walkthrough of the code. r=me > Source/WebCore/Modules/webaudio/Oscillator.cpp:211 > + outputBus->zero(); This is redundant; just return.
Chris Rogers
Comment 3 2012-05-04 18:27:49 PDT
Committed r116201: <http://trac.webkit.org/changeset/116201>
Note You need to log in before you can comment on or make changes to this bug.