|Summary:||Prepare RenderDeprecatedFlexibleBox for sub-pixel layout|
|Product:||WebKit||Reporter:||Levi Weintraub <leviw>|
|Severity:||Normal||CC:||dglazkov, eae, eric, webkit.review.bot|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Levi Weintraub 2012-04-30 11:24:58 PDT
One-line change to prevent an infinite loop in RenderDeprecatedFlexibleBox when it tries to distribute less than a pixel amongst its children.
Comment 2 Eric Seidel (no email) 2012-04-30 12:01:58 PDT
Comment on attachment 139492 [details] Patch OK.
Comment 3 WebKit Review Bot 2012-04-30 13:25:27 PDT
Comment on attachment 139492 [details] Patch Attachment 139492 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12593326 New failing tests: fast/flexbox/flex-hang.html
Comment 4 WebKit Review Bot 2012-04-30 13:25:33 PDT
Created attachment 139508 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 6 Levi Weintraub 2012-04-30 14:27:18 PDT
Turns out we need an abs() (soon to be absoluteValue!) for when the values are negative. The changelog is still accurate :)
Comment 7 Eric Seidel (no email) 2012-04-30 14:54:14 PDT
Comment on attachment 139517 [details] Patch ok, makes sense. I'm not sure how hot (if at all) this code is. If it turns out to be hot we could write this is faster ways I'm sure.
Comment 8 Levi Weintraub 2012-04-30 15:51:56 PDT
Comment on attachment 139517 [details] Patch Thanks again!
Comment 9 WebKit Review Bot 2012-04-30 16:02:18 PDT
Comment on attachment 139517 [details] Patch Clearing flags on attachment: 139517 Committed r115687: <http://trac.webkit.org/changeset/115687>
Comment 10 WebKit Review Bot 2012-04-30 16:02:32 PDT
All reviewed patches have been landed. Closing bug.
Comment 11 Darin Adler 2014-04-24 16:45:31 PDT