Bug 85217

Summary: Prepare RenderDeprecatedFlexibleBox for sub-pixel layout
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: JavaScriptCoreAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eae, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ec2-cr-linux-03
none
Patch none

Description Levi Weintraub 2012-04-30 11:24:58 PDT
One-line change to prevent an infinite loop in RenderDeprecatedFlexibleBox when it tries to distribute less than a pixel amongst its children.
Comment 1 Levi Weintraub 2012-04-30 11:36:06 PDT
Created attachment 139492 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-04-30 12:01:58 PDT
Comment on attachment 139492 [details]
Patch

OK.
Comment 3 WebKit Review Bot 2012-04-30 13:25:27 PDT
Comment on attachment 139492 [details]
Patch

Attachment 139492 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12593326

New failing tests:
fast/flexbox/flex-hang.html
Comment 4 WebKit Review Bot 2012-04-30 13:25:33 PDT
Created attachment 139508 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Levi Weintraub 2012-04-30 14:27:01 PDT
Created attachment 139517 [details]
Patch
Comment 6 Levi Weintraub 2012-04-30 14:27:18 PDT
Turns out we need an abs() (soon to be absoluteValue!) for when the values are negative. The changelog is still accurate :)
Comment 7 Eric Seidel (no email) 2012-04-30 14:54:14 PDT
Comment on attachment 139517 [details]
Patch

ok, makes sense.  I'm not sure how hot (if at all) this code is.  If it turns out to be hot we could write this is faster ways I'm sure.
Comment 8 Levi Weintraub 2012-04-30 15:51:56 PDT
Comment on attachment 139517 [details]
Patch

Thanks again!
Comment 9 WebKit Review Bot 2012-04-30 16:02:18 PDT
Comment on attachment 139517 [details]
Patch

Clearing flags on attachment: 139517

Committed r115687: <http://trac.webkit.org/changeset/115687>
Comment 10 WebKit Review Bot 2012-04-30 16:02:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Darin Adler 2014-04-24 16:45:31 PDT
Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue.