Bug 85205

Summary: [V8][Performance] Remove Isolate lookup from the call path to get a cached JS wrapper object by getDOMXXXXMap()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, arv, eric.carlson, feature-media-reviews, japhet, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84074    
Attachments:
Description Flags
Performance test
none
Patch none

Kentaro Hara
Reported 2012-04-30 10:14:31 PDT
By passing Isolate around, we can remove Isolate lookup from the call path to get a cached wrapper JS object by getDOMXXXXMap(). For example, this improves the performance of toV8(NodeList*) in getElementsByTagName(), getElementsByName() and getElementsByClassName().
Attachments
Performance test (1.69 KB, text/html)
2012-04-30 10:14 PDT, Kentaro Hara 		no flags
Details
Patch (19.22 KB, patch)
2012-04-30 10:15 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-04-30 10:14:50 PDT
Created attachment 139468 [details] Performance test
Kentaro Hara
Comment 2 2012-04-30 10:15:53 PDT
Created attachment 139469 [details] Patch
WebKit Review Bot
Comment 3 2012-05-06 21:38:49 PDT
Comment on attachment 139469 [details] Patch Clearing flags on attachment: 139469 Committed r116269: <http://trac.webkit.org/changeset/116269>
WebKit Review Bot
Comment 4 2012-05-06 21:38:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.