Bug 85205 - [V8][Performance] Remove Isolate lookup from the call path to get a cached JS wrapper object by getDOMXXXXMap()
Summary: [V8][Performance] Remove Isolate lookup from the call path to get a cached JS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 84074
  Show dependency tree / graph
 
Reported: 2012-04-30 10:14 PDT by Kentaro Hara
Modified: 2012-05-06 21:38 PDT (History)
7 users (show)

See Also:

Attachments
Performance test (1.69 KB, text/html)
2012-04-30 10:14 PDT, Kentaro Hara 		no flags Details
Patch (19.22 KB, patch)
2012-04-30 10:15 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-04-30 10:14:31 PDT 
By passing Isolate around, we can remove Isolate lookup from the call path to get a cached wrapper JS object by getDOMXXXXMap(). For example, this improves the performance of toV8(NodeList*) in getElementsByTagName(), getElementsByName() and getElementsByClassName().
Comment 1 Kentaro Hara 2012-04-30 10:14:50 PDT 
Created attachment 139468 [details]
Performance test
Comment 2 Kentaro Hara 2012-04-30 10:15:53 PDT 
Created attachment 139469 [details]
Patch
Comment 3 WebKit Review Bot 2012-05-06 21:38:49 PDT 
Comment on attachment 139469 [details]
Patch

Clearing flags on attachment: 139469

Committed r116269: <http://trac.webkit.org/changeset/116269>
Comment 4 WebKit Review Bot 2012-05-06 21:38:54 PDT 
All reviewed patches have been landed.  Closing bug.