Bug 85201

Summary: [chromium] Add WebDocument::referrerPolicy() which wraps the same method on Document
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

jochen
Reported 2012-04-30 08:39:38 PDT
[chromium] Check whether a frame with a document exists before querying its referrer policy
Attachments
Patch (1.46 KB, patch)
2012-04-30 08:39 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Patch (2.49 KB, patch)
2012-05-02 12:59 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-04-30 08:39:54 PDT
Created attachment 139456 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2012-05-02 10:07:55 PDT
Comment on attachment 139456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139456&action=review > Source/WebKit/chromium/src/WebFrameImpl.cpp:601 > + if (m_frame && m_frame->document()) This doesn't seem quite right. WebFrameImpl methods normally assume that m_frame is non-null. See all the other methods that just use m_frame without null checking it. We similarly have methods that assume m_frame->document() will be non-null, although many functions do null test document(). I think the right solution is actually to move referrerPolicy() to WebDocument since it is really a property of the Document instead of the Frame.
jochen
Comment 3 2012-05-02 12:59:55 PDT
Created attachment 139863 [details] Patch
WebKit Review Bot
Comment 4 2012-05-02 13:02:09 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 5 2012-05-02 14:39:24 PDT
Comment on attachment 139863 [details] Patch Clearing flags on attachment: 139863 Committed r115889: <http://trac.webkit.org/changeset/115889>
WebKit Review Bot
Comment 6 2012-05-02 14:39:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.