Bug 85172

Summary: Remove custom bindings code in JSHTMLCollectionCustom.cpp for HTMLPropertiesCollection.
Product: WebKit Reporter: Arko Saha <arko>
Component: New BugsAssignee: Arko Saha <arko>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 85216    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Arko Saha
Reported 2012-04-30 03:04:47 PDT
Remove custom bindings code in JSHTMLCollectionCustom.cpp for HTMLPropertiesCollection. We should use [JSGenerateToJSObject] in HTMLPropertiesCollection.idl, so that it can generate toJS() in JSHTMLPropertiesCollection.cpp automatically.
Attachments
Patch (2.27 KB, patch)
2012-04-30 03:14 PDT, Arko Saha 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Arko Saha
Comment 1 2012-04-30 03:14:15 PDT
Created attachment 139428 [details] Patch
Kentaro Hara
Comment 2 2012-04-30 06:06:23 PDT
Comment on attachment 139428 [details] Patch toJS() is generated into the generated code, and toJS() still exists in JSHTMLCollectionCustom.cpp. Won't it cause toJS() redefinition?
Arko Saha
Comment 3 2012-04-30 06:17:22 PDT
(In reply to comment #2) > (From update of attachment 139428 [details]) > toJS() is generated into the generated code, and toJS() still exists in JSHTMLCollectionCustom.cpp. Won't it cause toJS() redefinition? We are adding [JSGenerateToJSObject] in HTMLPropertiesCollection.idl, so it will generate toJS() in JSHTMLPropertiesCollection.cpp not in JSHTMLCollection.cpp. So it will not complain for redefination. I have also compiled the code changes in my local system. Its working as expected.
Kentaro Hara
Comment 4 2012-04-30 07:09:52 PDT
Comment on attachment 139428 [details] Patch Thanks for the clarification.
Arko Saha
Comment 5 2012-04-30 07:15:12 PDT
Comment on attachment 139428 [details] Patch Thanks haraken for the review.
WebKit Review Bot
Comment 6 2012-04-30 08:13:53 PDT
Comment on attachment 139428 [details] Patch Clearing flags on attachment: 139428 Committed r115638: <http://trac.webkit.org/changeset/115638>
WebKit Review Bot
Comment 7 2012-04-30 08:14:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.