Bug 8517

Summary:

change DerivedSources.make to use VPATH consistently

Product:

WebKit

Reporter:

Michael Emmel <mike.emmel>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Trivial

Priority:

Version:

420+

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

8515

Attachments:

Description	Flags
patch to add WebCore variable	darin: review-
Patch to make more paths use VPATH	mjs: review+

Michael Emmel

Reported 2006-04-21 08:24:54 PDT

Make all pathes relative to $(WebCore) in DerivedSource.make

Attachments
patch to add WebCore variable (2.01 KB, patch) 2006-04-21 08:26 PDT, Michael Emmel	darin: review-	Details Formatted Diff Diff
Patch to make more paths use VPATH (2.70 KB, patch) 2006-04-21 23:20 PDT, Michael Emmel	mjs: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Emmel

Comment 1 2006-04-21 08:26:12 PDT

Created attachment 7872 [details] patch to add WebCore variable

Geoffrey Garen

Comment 2 2006-04-21 11:29:41 PDT

Comment on attachment 7872 [details] patch to add WebCore variable r=me

Eric Seidel (no email)

Comment 3 2006-04-21 14:26:22 PDT

Comment on attachment 7872 [details] patch to add WebCore variable This should not be necessary. the VPATH variable should take care of this...

Darin Adler

Comment 4 2006-04-21 22:23:18 PDT

Comment on attachment 7872 [details] patch to add WebCore variable This is not a good idea. VPATH is supposed to handle this. Please don't land this change until we understand why that's not working.

Michael Emmel

Comment 5 2006-04-21 22:36:21 PDT

(In reply to comment #4) > (From update of attachment 7872 [details] [edit]) > This is not a good idea. VPATH is supposed to handle this. Please don't land > this change until we understand why that's not working. > It works its just at one point when I made the patch all paths were not relative I don't think the makefile actually worked at that time it does now. With that said all paths are not relative in the make file for example ksvgcssvalues.h : $(WebCore)/ksvg2/scripts/cssmakevalues $(WebCore)/css/CSSValue So its a mix of relative paths using the VPATH and some that don't. I went the route of all absolute which I can understand not using but we should make it all relative or all absolute not a mix

Michael Emmel

Comment 6 2006-04-21 23:20:22 PDT

Created attachment 7894 [details] Patch to make more paths use VPATH This patch makes the makefile more consitent in its use of VPATH. Note VPATH works with the latest version in SVN the orginal patch was made agianst and older version of the file that had several problems.

Maciej Stachowiak

Comment 7 2006-04-22 12:52:09 PDT

Comment on attachment 7894 [details] Patch to make more paths use VPATH r=me

Note You need to log in before you can comment on or make changes to this bug.