|Summary:||change DerivedSources.make to use VPATH consistently|
|Product:||WebKit||Reporter:||Michael Emmel <mike.emmel>|
|Bug Depends on:|
Description Michael Emmel 2006-04-21 08:24:54 PDT
Make all pathes relative to $(WebCore) in DerivedSource.make
Comment 1 Michael Emmel 2006-04-21 08:26:12 PDT
Created attachment 7872 [details] patch to add WebCore variable
Comment 2 Geoffrey Garen 2006-04-21 11:29:41 PDT
Comment on attachment 7872 [details] patch to add WebCore variable r=me
Comment 3 Eric Seidel (no email) 2006-04-21 14:26:22 PDT
Comment on attachment 7872 [details] patch to add WebCore variable This should not be necessary. the VPATH variable should take care of this...
Comment 4 Darin Adler 2006-04-21 22:23:18 PDT
Comment on attachment 7872 [details] patch to add WebCore variable This is not a good idea. VPATH is supposed to handle this. Please don't land this change until we understand why that's not working.
Comment 5 Michael Emmel 2006-04-21 22:36:21 PDT
(In reply to comment #4) > (From update of attachment 7872 [details] ) > This is not a good idea. VPATH is supposed to handle this. Please don't land > this change until we understand why that's not working. > It works its just at one point when I made the patch all paths were not relative I don't think the makefile actually worked at that time it does now. With that said all paths are not relative in the make file for example ksvgcssvalues.h : $(WebCore)/ksvg2/scripts/cssmakevalues $(WebCore)/css/CSSValue So its a mix of relative paths using the VPATH and some that don't. I went the route of all absolute which I can understand not using but we should make it all relative or all absolute not a mix
Comment 6 Michael Emmel 2006-04-21 23:20:22 PDT
Created attachment 7894 [details] Patch to make more paths use VPATH This patch makes the makefile more consitent in its use of VPATH. Note VPATH works with the latest version in SVN the orginal patch was made agianst and older version of the file that had several problems.