| Summary: | [EFL] Default values for ewk_view video tracks settings should be documented | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2012-04-29 22:28:57 PDT
Created attachment 139419 [details]
Patch
Comment on attachment 139419 [details]
Patch
Looks fine.
Comment on attachment 139419 [details]
Patch
Could you mention the defaults in the getters as well?
(In reply to comment #3) > (From update of attachment 139419 [details]) > Could you mention the defaults in the getters as well? Do you mean the setters? Somehow, it feels weird to me to provide default values in the setters documentation. This is why my patch updates the documentation for the getters only. (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 139419 [details] [details]) > > Could you mention the defaults in the getters as well? > > Do you mean the setters? Somehow, it feels weird to me to provide default values in the setters documentation. This is why my patch updates the documentation for the getters only. Oops, I was confused by the function names the review page showed (it showed the setters, so I thought you had not documented the getters). LGTM again. Comment on attachment 139419 [details] Patch Clearing flags on attachment: 139419 Committed r117617: <http://trac.webkit.org/changeset/117617> All reviewed patches have been landed. Closing bug. |