Bug 85142

Summary: Clarified JSGlobalData (JavaScript VM) lifetime
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, barraclough, fpizlo, mhahnenberg, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ap: review+

Geoffrey Garen
Reported 2012-04-28 12:18:24 PDT
Clarified JSGlobalData (JavaScript VM) lifetime
Attachments
Patch (33.61 KB, patch)
2012-04-28 13:15 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (2.06 KB, patch)
2012-05-08 18:28 PDT, Geoffrey Garen 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2012-04-28 13:15:37 PDT
Created attachment 139371 [details] Patch
Anders Carlsson
Comment 2 2012-04-28 13:26:20 PDT
Comment on attachment 139371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139371&action=review > Source/JavaScriptCore/ChangeLog:37 > + notwithstaning, C++ does in fact know how to execute destructors in Speling error, notwithstaning. > Source/JavaScriptCore/runtime/JSGlobalData.h:155 > + Heap heap; Could you add a comment here about the destruction order so nobody will accidentally move this?
Early Warning System Bot
Comment 3 2012-04-28 13:27:17 PDT
Comment on attachment 139371 [details] Patch Attachment 139371 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12552666
Early Warning System Bot
Comment 4 2012-04-28 13:32:06 PDT
Comment on attachment 139371 [details] Patch Attachment 139371 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12553679
Build Bot
Comment 5 2012-04-28 13:36:42 PDT
Comment on attachment 139371 [details] Patch Attachment 139371 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12558684
Geoffrey Garen
Comment 6 2012-04-28 13:50:33 PDT
Committed r115579: <http://trac.webkit.org/changeset/115579>
Alexey Proskuryakov
Comment 7 2012-04-30 11:11:50 PDT
Comment on attachment 139371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139371&action=review > Source/JavaScriptCore/ChangeLog:42 > + (JSGlobalContextCreate): Removed compatibility shim for older > + operating systems because it's no longer used. This was not a shim for older operating systems, this was for applications linked against older versions of WebKit. I think that this removal is a mistake.
Geoffrey Garen
Comment 8 2012-05-08 18:21:06 PDT
Reopening, because Alexey is right.
Geoffrey Garen
Comment 9 2012-05-08 18:28:24 PDT
Created attachment 140839 [details] Patch
Alexey Proskuryakov
Comment 10 2012-05-08 21:42:10 PDT
Geoff, please file a Radar for the follow-up fix.
Geoffrey Garen
Comment 11 2012-05-11 15:13:35 PDT
<rdar://problem/11437914>
Geoffrey Garen
Comment 12 2012-05-11 15:16:05 PDT
Committed r116809: <http://trac.webkit.org/changeset/116809>
Note You need to log in before you can comment on or make changes to this bug.