Bug 85137

Summary: Web Inspector: InspectorFrontendHost.append has to be implemented for saving heap snapshots
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, dglazkov, fishd, jamesr, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, tkent+wkapi, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
pfeldman: review+
Patch none

Ilya Tikhonovsky
Reported 2012-04-28 06:38:06 PDT
We can save a file with help of InspectorFrontendHost.save method, but it is suitable only for relatively small portions of data and can't process the 6Gb heap snapshot.
Attachments
Patch (8.44 KB, patch)
2012-04-28 06:50 PDT, Ilya Tikhonovsky 		pfeldman: review+
DetailsFormatted DiffDiff
Patch (7.99 KB, patch)
2012-04-28 07:07 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-04-28 06:50:19 PDT
Created attachment 139360 [details] Patch
WebKit Review Bot
Comment 2 2012-04-28 06:53:50 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Ilya Tikhonovsky
Comment 3 2012-04-28 07:07:32 PDT
Created attachment 139361 [details] Patch
Yury Semikhatsky
Comment 4 2012-04-28 09:56:13 PDT
Comment on attachment 139361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139361&action=review > Source/WebCore/inspector/InspectorFrontendClient.h:64 > + virtual void append(const WTF::String& url, const WTF::String& content) = 0; We may want bool forceSaveAs argument here, otherwise the only way to change the file path would be to call save() for the URL and then append.
Ilya Tikhonovsky
Comment 5 2012-04-28 12:11:07 PDT
Comment on attachment 139361 [details] Patch Clearing flags on attachment: 139361 Committed r115577: <http://trac.webkit.org/changeset/115577>
Ilya Tikhonovsky
Comment 6 2012-04-28 12:11:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.