Bug 85136

Summary:

Web Inspector: migrate breakpoint manager to live locations.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ec2-cr-linux-01	none
[Patch] Same with extensive test coverage	none
Archive of layout-test-results from ec2-cr-linux-02	none
[Patch] with formatter test fixed	none
Patch	yurys: review+

Pavel Feldman

Reported 2012-04-28 05:40:16 PDT

- Merges Breakpoint and UIBreakpoint to have single instance - Extracts storage from the breakpoint manager - Makes breakpoint manager use source mapping from the script, not the presentation model - Removes breakpoints collection from the UISourceCode Unfortunately, there are too many inter-dependencies that require that these changes are done simultaneously.

Attachments
Patch (105.12 KB, patch) 2012-04-28 05:48 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (108.54 KB, patch) 2012-04-30 09:06 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-01 (5.75 MB, application/zip) 2012-04-30 10:48 PDT, WebKit Review Bot	no flags	Details
[Patch] Same with extensive test coverage (122.06 KB, patch) 2012-05-01 08:49 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-02 (5.95 MB, application/zip) 2012-05-01 09:21 PDT, WebKit Review Bot	no flags	Details
[Patch] with formatter test fixed (122.89 KB, patch) 2012-05-01 23:38 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (125.33 KB, patch) 2012-05-02 09:53 PDT, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2012-04-28 05:48:44 PDT

Created attachment 139358 [details] Patch

Pavel Feldman

Comment 2 2012-04-30 09:06:23 PDT

Created attachment 139459 [details] Patch

WebKit Review Bot

Comment 3 2012-04-30 10:48:00 PDT

Comment on attachment 139459 [details] Patch Attachment 139459 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12588297 New failing tests: inspector/debugger/script-formatter-breakpoints.html

WebKit Review Bot

Comment 4 2012-04-30 10:48:07 PDT

Created attachment 139475 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Pavel Feldman

Comment 5 2012-05-01 08:49:27 PDT

Created attachment 139632 [details] [Patch] Same with extensive test coverage

WebKit Review Bot

Comment 6 2012-05-01 09:21:23 PDT

Comment on attachment 139632 [details] [Patch] Same with extensive test coverage Attachment 139632 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12582675 New failing tests: inspector/debugger/script-formatter-breakpoints.html

WebKit Review Bot

Comment 7 2012-05-01 09:21:31 PDT

Created attachment 139636 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Pavel Feldman

Comment 8 2012-05-01 23:38:20 PDT

Created attachment 139755 [details] [Patch] with formatter test fixed

Pavel Feldman

Comment 9 2012-05-02 09:53:33 PDT

Created attachment 139833 [details] Patch

Pavel Podivilov

Comment 10 2012-05-02 10:17:04 PDT

Comment on attachment 139833 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139833&action=review looks good. > Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:59 > + this._breakpointRemoved(event); Should be "if (this._items.contains(breakpoint)) return". > Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:44 > + this._breakpoints = {}; Could you please remove this map?

Pavel Feldman

Comment 11 2012-05-03 05:07:41 PDT

Committed r115961: <http://trac.webkit.org/changeset/115961>

Note You need to log in before you can comment on or make changes to this bug.