Bug 85129

Summary:

Rename SVGPathParserFactory to SVGPathUtilities and remove the obsolete singleton

Product:

WebKit

Reporter:

Nikolas Zimmermann <zimmermann>

Component:

SVG

Assignee:

Nikolas Zimmermann <zimmermann>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy, rakuco, webkit.review.bot, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	webkit-ews: commit-queue-

Nikolas Zimmermann

Reported 2012-04-28 01:40:44 PDT

Rename SVGPathParserFactory to SVGPathUtilities and remove the obsolete singleton

Attachments
Patch (61.59 KB, patch) 2012-04-28 02:19 PDT, Nikolas Zimmermann	webkit-ews: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Nikolas Zimmermann

Comment 1 2012-04-28 02:19:17 PDT

Created attachment 139346 [details] Patch

Antti Koivisto

Comment 2 2012-04-28 02:25:47 PDT

Comment on attachment 139346 [details] Patch Hope this is move rather than copy.

Nikolas Zimmermann

Comment 3 2012-04-28 02:28:53 PDT

Committed r115560: <http://trac.webkit.org/changeset/115560>

Csaba Osztrogonác

Comment 4 2012-04-28 02:33:21 PDT

Reopen, because it broke the Qt build: ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromCircleElement(WebCore::SVGElement*, WebCore::Path&)': ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:45: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromEllipseElement(WebCore::SVGElement*, WebCore::Path&)': ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:60: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromLineElement(WebCore::SVGElement*, WebCore::Path&)': ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:69: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:70: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromPolygonElement(WebCore::SVGElement*, WebCore::Path&)': ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:88: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:92: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:94: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromPolylineElement(WebCore::SVGElement*, WebCore::Path&)': ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:106: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:110: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromRectElement(WebCore::SVGElement*, WebCore::Path&)': ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:139: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:139: error: incomplete type 'WebCore::Path' used in nested name specifier ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:143: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' Could you fix it?

Early Warning System Bot

Comment 5 2012-04-28 02:34:42 PDT

Comment on attachment 139346 [details] Patch Attachment 139346 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12487028

Early Warning System Bot

Comment 6 2012-04-28 02:36:06 PDT

Comment on attachment 139346 [details] Patch Attachment 139346 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12556548

Nikolas Zimmermann

Comment 7 2012-04-28 02:44:28 PDT

Really sorry for not waiting for Qt EWS, I'll be sure to do that next time, landed Qt buildfix in r115561.

Note You need to log in before you can comment on or make changes to this bug.