Bug 85121

Summary: Implement reverse animation direction on Windows CoreAnimation
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Invalid Patch
none
Patch
none
Patch none

Dean Jackson
Reported 2012-04-27 20:15:18 PDT
Windows falls back to software animation when the direction is reverse or alternate-reverse.
Attachments
Invalid Patch (1.63 KB, patch)
2013-10-16 13:57 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (7.07 KB, patch)
2013-10-21 17:34 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (7.35 KB, patch)
2013-10-21 17:49 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-04-27 20:16:03 PDT
<rdar://problem/11341982>
Brent Fulgham
Comment 2 2013-10-15 13:58:15 PDT
Example: LayoutTests/animations/animation-direction-reverse-timing-functions.html LayoutTests/animations/animation-direction-reverse-timing-functions-hardware.html The latter should be completely hardware-accelerated.
Brent Fulgham
Comment 3 2013-10-16 13:55:14 PDT
Running the tests on recent AAS it seems that this is working properly.
Brent Fulgham
Comment 4 2013-10-16 13:57:55 PDT
Created attachment 214391 [details] Invalid Patch
Simon Fraser (smfr)
Comment 5 2013-10-16 14:18:39 PDT
Comment on attachment 214391 [details] Invalid Patch Please mention the radar number too.
Brent Fulgham
Comment 6 2013-10-16 14:36:12 PDT
This patch will be correct in a future version of CoreGraphics.
Brent Fulgham
Comment 7 2013-10-21 16:34:49 PDT
CoreGraphics is fine. The Windows port was simply missing logic to invert the control points used in the timing function (see toCAMediaTimingFunction in PlatformCAAnimationMac.mm for details).
Brent Fulgham
Comment 8 2013-10-21 17:34:17 PDT
Created attachment 214800 [details] Patch
Dean Jackson
Comment 9 2013-10-21 17:41:20 PDT
Comment on attachment 214800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214800&action=review > Source/WebCore/platform/animation/TimingFunction.h:145 > + return adoptRef(new CubicBezierTimingFunction(Ease, 1.0 - m_x2, 1.0 - m_y2, 1.0 - m_x1, 1.0 - m_y1)); As discussed on IRC... BTW - why not return CubicBezierTimingFunction::create(new points); ?
Brent Fulgham
Comment 10 2013-10-21 17:49:02 PDT
Created attachment 214802 [details] Patch
WebKit Commit Bot
Comment 11 2013-10-21 19:03:43 PDT
Comment on attachment 214802 [details] Patch Clearing flags on attachment: 214802 Committed r157773: <http://trac.webkit.org/changeset/157773>
WebKit Commit Bot
Comment 12 2013-10-21 19:03:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.