Summary: | vertexAttribPointer needs to reject large negative offsets | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||||
Component: | WebGL | Assignee: | Zhenyao Mo <zmo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, aestes, dino, fpizlo, gman, jamesr, ojan, oliver, webkit.review.bot, zmo | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 85722 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Kenneth Russell
2012-04-27 18:39:14 PDT
Taking this one. It's the last bug fix to make chrome webgl 1.0.1 conformant. Created attachment 140358 [details]
Patch
Tested in chromium and webkit on Mac. The test is synced from khronos. Please have a look. (I used long long in place of GLsizeiptr and GLintptr to be consistent with the types used in the bindings) Comment on attachment 140358 [details]
Patch
Looks good. r=me
Let's wait for it to clear the EWS before committing though.
Comment on attachment 140358 [details] Patch Clearing flags on attachment: 140358 Committed r116221: <http://trac.webkit.org/changeset/116221> All reviewed patches have been landed. Closing bug. This breaks the build on platforms that compile with -Wshorten-64-to-32, since there are now several call sites that pass a long long to a function that expects a GC3Dintptr. Reopening because of the breakage that Andy is talking about. Sorry, but I have to roll this out. :-( Please let me know if you need assistance debugging the build errors we're seeing. Created attachment 140538 [details]
Patch
Comment on attachment 140538 [details]
Patch
Ken, I added explicit converting from long long to GC3D types to avoid compiling failures on 32.
Please have another look.
The new patch builds for me on the same machine that couldn't build the last patch. Thanks Andy for testing this out. Comment on attachment 140538 [details]
Patch
New patch looks OK as long as it compiles. It's a little unfortunate that we lose the ability to change the signatures here with one typedef.
Committed r116374: <http://trac.webkit.org/changeset/116374> *** Bug 85528 has been marked as a duplicate of this bug. *** |