Bug 85115

Summary:

Remove SHADER_COMPILER constant

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

WebGL

Assignee:

Kenneth Russell <kbr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dino, gman, jamesr, ojan, webkit.review.bot, zmo

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Kenneth Russell 2012-04-27 18:05:15 PDT

The SHADER_COMPILER constant was removed from the WebGL spec some time ago, but its removal wasn't verified by the conformance suite. It is being now, and needs to be removed from WebKit's implementation.

Comment 1 Kenneth Russell 2012-04-27 18:07:50 PDT

Created attachment 139312 [details]
Patch

Comment 2 Darin Adler 2012-04-27 18:12:32 PDT

Comment on attachment 139312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139312&action=review

> LayoutTests/fast/canvas/webgl/constants.html:449
> +NUM_COMPRESSED_TEXTURE_FORMATS : 0x86A2,
> +FIXED                          : 0x140C,
> +ACTIVE_UNIFORM_MAX_LENGTH      : 0x8B87,
> +ACTIVE_ATTRIBUTE_MAX_LENGTH    : 0x8B8A,
> +EXTENSIONS                     : 0x1F03,
> +INFO_LOG_LENGTH                : 0x8B84,
> +SHADER_SOURCE_LENGTH           : 0x8B88,
> +SHADER_COMPILER                : 0x8DFA,
> +SHADER_BINARY_FORMATS          : 0x8DF8,
> +NUM_SHADER_BINARY_FORMATS      : 0x8DF9,

Heh, it’s funny to have the actual values here for the removed constants.

Comment 3 Kenneth Russell 2012-04-27 18:19:20 PDT

(In reply to comment #2)
> Heh, it’s funny to have the actual values here for the removed constants.

Yeah, maybe that was dumb of me...

Comment 4 WebKit Review Bot 2012-04-27 20:20:09 PDT

Comment on attachment 139312 [details]
Patch

Clearing flags on attachment: 139312

Committed r115531: <http://trac.webkit.org/changeset/115531>

Comment 5 WebKit Review Bot 2012-04-27 20:20:14 PDT

All reviewed patches have been landed.  Closing bug.